Skip to content

🐛 Fix two bot-review issues in handoff-context#50

Open
TechNickAI wants to merge 1 commit intomainfrom
review-sweep/handoff-context-polish
Open

🐛 Fix two bot-review issues in handoff-context#50
TechNickAI wants to merge 1 commit intomainfrom
review-sweep/handoff-context-polish

Conversation

@TechNickAI
Copy link
Copy Markdown
Owner

Summary

Addresses 2 remaining polish issues from Claude bot review of PR #49:

  • Framework-neutral example: Replaced Next.js-specific cookies().set(...) with generic cookie configuration example
  • Clearer recommendations framing: Changed "backup to exact_next_step" → "beyond exact_next_step" to clarify additive relationship

Context

PR #49 was already merged after fixing the critical issues. These are minor polish improvements flagged in Claude's follow-up review.

Changes

Before:

e.g., "In app/api/auth/login/route.ts line 42, set the JWT as httpOnly cookie via cookies().set(...)..."
[Actionable next steps in priority order, as a backup to exact_next_step.]

After:

e.g., "In auth/login.ts line 42, add httpOnly flag to the session cookie configuration..."
[Additional actionable next steps beyond exact_next_step, in priority order.]

🤖 Generated by review-sweep process from PR #49

- Replace Next.js-specific example with framework-neutral one
- Clarify recommendations as additive, not fallback

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@claude
Copy link
Copy Markdown

claude Bot commented Apr 22, 2026

Code Review: PR #50 — Fix two bot-review issues in handoff-context

Overall: Clean, well-scoped polish PR. Both changes improve the quality and clarity of the handoff-context command template.


What this PR does

Two targeted improvements to plugins/core/commands/handoff-context.md:

  1. Replaces a Next.js-specific example (app/api/auth/login/route.ts, cookies().set(...)) with a framework-neutral one
  2. Clarifies that <recommendations> are additive steps beyond exact_next_step, not fallbacks to it

Analysis

Framework-neutral example — ✅ Correct fix

The original example was tightly coupled to Next.js conventions (cookies().set(...), the app/api/ directory structure). The replacement is more universally applicable and the reworded instruction (add httpOnly flag to the session cookie configuration) is clearer than the API-call-style example. The updated curl verification note (includes HttpOnly) is also more precise.

Recommendations framing — ✅ Correct fix

"as a backup to exact_next_step" implied the recommendations are only needed if exact_next_step is absent or fails. "beyond exact_next_step" correctly communicates they are supplementary priority-ordered steps, which aligns with how a developer would actually use the handoff.


Minor observation

The closing </exact_next_step> tag moved from its own line to inline with the example text:

Set-Cookie header includes HttpOnly."] </exact_next_step>

The original had the tag on a dedicated line. This is a cosmetic inconsistency — the inline placement looks slightly cramped. Consider keeping the closing tag on its own line for consistency with the rest of the XML-style structure in this template. Not a blocker.


Checklist

  • Change is minimal and well-targeted
  • No new logic introduced — documentation/prompt template only
  • No security or performance implications
  • Follows project conventions (Markdown, XML-style prompt tags)
  • Minor: closing tag formatting (see above)

Verdict: Approve with the optional suggestion to move the closing tag to its own line for consistency.

🤖 Reviewed by claude[bot]

@TechNickAI
Copy link
Copy Markdown
Owner Author

Thanks for the review! The inline closing tag is Prettier's proseWrap: always behavior (same as discussed in #49). The structural tags are present and parseable — Prettier just prefers inline placement when the content fits. Since this matches the rest of the file's formatting and both main fixes are approved, keeping as-is.

@TechNickAI TechNickAI added review-sweep Automated review sweep fixes Hex Generated by Hex labels Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hex Generated by Hex review-sweep Automated review sweep fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant