Conversation
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
==========================================
- Coverage 84.81% 84.64% -0.17%
==========================================
Files 99 99
Lines 2410 2410
Branches 184 184
==========================================
- Hits 2044 2040 -4
Misses 312 312
- Partials 54 58 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The C# 14 redundant-pattern fix changed the `ActionApiToken` guard line, which left it only partially branch-covered (the empty/null path was never exercised), failing the codecov patch check. Add tests for both the configured and not-configured cases. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
JadynWong
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
net10.0;net9.0;net8.0(thenetstandard2.1core libraries are unchanged).Target frameworks
net9.0;net8.0;net6.0→net10.0;net9.0;net8.0across all multi-target src/test projects andcommon.testing.props.Dependency updates (
Directory.Build.props)Also: package version 1.4.0 → 1.5.0, ConfigureAwait.Fody 3.4.1, coverlet.collector 6.0.4 → 10.0.1, xunit.runner.visualstudio 3.1.4 → 3.1.5.
CI workflows
test.yml: installed SDKs6.0.x/7.0.x/9.0.x→8.0.x/9.0.x/10.0.xpublish.yml:9.0.x→10.0.xIncidental fix
The C# 14 analyzer surfaced
CS9336inDtmGrpcTmClient.cs:is not null or ""parses as(is not null) or (is ""), i.e. justis not null— theor ""was dead code, contrary to the apparent intent ("not null and not empty"). Changed tois not (null or ""). Note: this changes runtime behavior for an empty-stringActionApiToken(the header is no longer added).Testing
dotnet build(Debug & Release): 0 errors.🤖 Generated with Claude Code