fix: match short flags when ShortPrefix and LongPrefix are identical (#26) - #197
Open
terrabeckhub wants to merge 2 commits into
Open
fix: match short flags when ShortPrefix and LongPrefix are identical (#26)#197terrabeckhub wants to merge 2 commits into
terrabeckhub wants to merge 2 commits into
Conversation
Owner
|
I'm still not sure if I like this pattern. You should be able to specify This kind of argument matching is pretty ugly and ambiguous. I don't like having the short flag the same as the long flag; it becomes inconsistent and difficult to reason about from a user perspective. I'd prefer making |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Windows-style identical
/short and long prefixes so/hmatches short flags (#26).When
ShortPrefix("/")andLongPrefix("/")are the same, every flag looked both short and long. The previous rule preferred the long form, so/hwas parsed as a long flag namedhand failed even though a shorthexisted.Change
If the prefixes are identical, prefer
ShortFlagwhen the next character is a registered short flag (covers/hand joined values like/ifile.txt); otherwise keepLongFlagfor names like/help.Test
Adds
test/windows_slash_prefix.cxx.Closes #26