Skip to content

Bbox fix--unscale OSM lat/long values#52

Merged
jeffmaki merged 1 commit into
developfrom
bbox-fix
Jul 9, 2026
Merged

Bbox fix--unscale OSM lat/long values#52
jeffmaki merged 1 commit into
developfrom
bbox-fix

Conversation

@jeffmaki

@jeffmaki jeffmaki commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Adjusted OSMRepository.getWorkspaceBBox to unscale OSM node latitude/longitude values when computing workspace bounding boxes, dividing the stored 1e7-scaled coordinates by 1e7 before returning results. The method’s not-found behavior is unchanged.

@jeffmaki jeffmaki merged commit d1fd279 into develop Jul 9, 2026
2 of 3 checks passed
@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 182cc20b-461c-47e3-9457-5a0579812baf

📥 Commits

Reviewing files that changed from the base of the PR and between dda4920 and 402f5c2.

📒 Files selected for processing (1)
  • api/src/osm/repository.py

📝 Walkthrough

Walkthrough

The SQL query in OSMRepository.getWorkspaceBBox was modified to divide the MAX/MIN latitude and longitude aggregates by 1e7, converting stored integer-scaled coordinates into decimal degree values.

Changes

Bounding Box Coordinate Conversion

Layer / File(s) Summary
Convert bbox coordinates to decimal degrees
api/src/osm/repository.py
The bounding box SQL query now divides MAX/MIN latitude and longitude aggregates by 1e7 to return decimal degree coordinates instead of raw scaled integers.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A hop, a scale, a tiny bug,
Coordinates once too snug.
Divide by ten million, clean and neat,
Now my map hops are precise and sweet! 🐰🗺️


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jeffmaki jeffmaki deleted the bbox-fix branch July 9, 2026 14:23
@jeffmaki jeffmaki restored the bbox-fix branch July 9, 2026 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant