test: add pure-Python tests + fix TaskSettings.add_subinfo save_path#20
Open
HugoFara wants to merge 2 commits intoTaskBeacon:mainfrom
Open
test: add pure-Python tests + fix TaskSettings.add_subinfo save_path#20HugoFara wants to merge 2 commits intoTaskBeacon:mainfrom
HugoFara wants to merge 2 commits intoTaskBeacon:mainfrom
Conversation
…ials These tests run in CI without psychopy/numpy. They cover: - sim/loader: _deep_get, _import_attr, _resolve_spec helpers - sim/logging: _to_jsonable serialization, JSONL logger roundtrip - utils/trials: trial counter, resolve_deadline, resolve_trial_id
The else branch incorrectly printed "Output directory already exists: None" when save_path was falsy. Also guard os.path.join calls that would crash with TypeError on None save_path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, two changes in this PR
Bug fix in
TaskSettings.add_subinfo()The
elsebranch at line 183 printed"Output directory already exists: None"whensave_pathwasNoneor empty. Also,os.path.join()crashed withTypeErroronNonesave_path. Fixed by nesting the exists-check inside theif self.save_pathguard.Pure-Python test coverage
Added 3 test files (
test_sim_loader.py,test_sim_logging.py,test_utils_trials.py) covering sim/loader helpers, JSONL logging roundtrip, and trial ID/deadline utilities. All run in CI without psychopy/numpy — no skips.These new tests will help preventing regressions.