Draft: minimal stuck GCSFuse pod retry prototype#285
Closed
Volv-G wants to merge 1 commit into
Closed
Conversation
Assisted-By: devx/ba25adb1-db34-47af-bfef-ecf43bc6627a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft PR to gauge the team's opinion on a minimal stuck-pod retry prototype. This is intentionally narrow and not ready to merge without team review/feedback.
This prototype:
launcher_data["kubernetes"]["pod_retry"].Safety constraints / scope
ownerReferencesand this does not alter Job retry behavior.PendingCreateContainerConfigErrorfailed to prepare subPathandgcsfuse1.Failed/Succeededstates.ERRORso the existing orchestrator behavior can stop leaving it pending forever.Validation
cd backend PYTHONPATH=. uv run --frozen pytest tests/test_kubernetes_pod_retry.py -q PYTHONPATH=. uv run --frozen black --check --target-version py310 cloud_pipelines_backend/launchers/kubernetes_launchers.py tests/test_kubernetes_pod_retry.pyResults:
4 passedNotes
This PR is opened against
TangleML/tanglebecause the actual changed code lives in the nestedbackendrepository/submodule used byShopify/oasis-backend.