feat: Integration API — proxy endpoint for external workflow triggers#284
Closed
morgan-wowk wants to merge 0 commit into
Closed
feat: Integration API — proxy endpoint for external workflow triggers#284morgan-wowk wants to merge 0 commit into
morgan-wowk wants to merge 0 commit into
Conversation
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
| if _slack_workflow_urls_raw: | ||
| try: | ||
| _slack_workflow_urls = json.loads(_slack_workflow_urls_raw) | ||
| except json.JSONDecodeError: |
Collaborator
Author
|
Moving this implementation to Shopify/oasis-backend instead — the Slack proxy endpoint will be Shopify-internal only for now. |
376c071 to
a57e9e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
POST /api/integration/slack_workflow_trigger— a server-side proxy that accepts a logical workflow identifier + arbitrary payload, resolves the target webhook URL from server configuration, and forwards the payload.workflowIdis needed in the client.TANGLE_SLACK_WORKFLOW_URLSenv var, a JSON object mapping workflow IDs to URLs). The endpoint is absent (404) in unconfigured OSS deployments.api_server_main.pyreadsTANGLE_SLACK_WORKFLOW_URLSfrom the environment (JSON string), parses it, and passes the mapping tosetup_routes().New files
cloud_pipelines_backend/integration_api.py—IntegrationApiService+register_routes()Modified files
cloud_pipelines_backend/api_router.py— threadsslack_workflow_urlsthroughsetup_routes()→_setup_routes_internal(), callsintegration_api.register_routes()beforeapp.include_router()api_server_main.py— reads + parsesTANGLE_SLACK_WORKFLOW_URLSenv var, passes tosetup_routes()Test plan
TANGLE_SLACK_WORKFLOW_URLS={}— confirm/api/integration/slack_workflow_triggerreturns 404TANGLE_SLACK_WORKFLOW_URLS={"test_wf": "https://example.com/hook"}— confirm POST with{"workflow_internal_id": "test_wf", "webhook_payload": {}}routes to the URLworkflow_internal_idreturns 404 with descriptive message🤖 Generated with Claude Code