Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,79 @@
import { act, fireEvent, render, screen } from "@testing-library/react";
import type { ReactNode } from "react";
import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";

import { ComponentSearchV2Content } from "./ComponentSearchV2Content";

const mocks = vi.hoisted(() => ({
useComponentSearchV2State: vi.fn(),
useFlagValue: vi.fn(),
}));

vi.mock(
"@/components/shared/ReactFlow/FlowSidebar/components/ImportComponent",
() => ({
default: ({ triggerComponent }: { triggerComponent: ReactNode }) => (
<>{triggerComponent}</>
),
}),
);

vi.mock("@/components/shared/Settings/useFlags", () => ({
useFlagValue: mocks.useFlagValue,
}));

vi.mock("@/routes/v2/pages/Editor/hooks/useComponentSearchV2State", () => ({
useComponentSearchV2State: mocks.useComponentSearchV2State,
}));

vi.mock("./ComponentSearchResults", () => ({
ComponentSearchResults: ({ query }: { query: string }) => (
<div data-testid="results-query">{query}</div>
),
}));

describe("ComponentSearchV2Content", () => {
beforeEach(() => {
vi.useFakeTimers();
mocks.useFlagValue.mockReturnValue(false);
mocks.useComponentSearchV2State.mockImplementation(() => ({
results: [],
browseFolders: [],
isLoading: false,
canRerank: false,
canDeepRerank: false,
isReranking: false,
isRerankActive: false,
rerank: vi.fn(),
deepRerank: vi.fn(),
clearRerank: vi.fn(),
}));
});

afterEach(() => {
vi.useRealTimers();
});

it("keeps typing local while delaying result query updates", async () => {
render(<ComponentSearchV2Content />);

const input = screen.getByLabelText("Search components");

fireEvent.change(input, { target: { value: "csv" } });

expect(input).toHaveValue("csv");
expect(screen.getByTestId("results-query")).toHaveTextContent("");

await act(async () => {
vi.advanceTimersByTime(499);
});

expect(screen.getByTestId("results-query")).toHaveTextContent("");

await act(async () => {
vi.advanceTimersByTime(1);
});

expect(screen.getByTestId("results-query")).toHaveTextContent("csv");
});
});
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { useState } from "react";
import { useDeferredValue, useState, useTransition } from "react";

import ImportComponent from "@/components/shared/ReactFlow/FlowSidebar/components/ImportComponent";
import { useFlagValue } from "@/components/shared/Settings/useFlags";
Expand All @@ -13,12 +13,17 @@ import { useComponentSearchV2State } from "@/routes/v2/pages/Editor/hooks/useCom

import { ComponentSearchResults } from "./ComponentSearchResults";

const EDITOR_SEARCH_RESULT_DEBOUNCE_MS = 500;

function DebouncedComponentSearchInput({
onCommit,
}: {
onCommit: (value: string) => void;
}) {
const [localValue, setLocalValue] = useDebouncedSearchValue(onCommit);
const [localValue, setLocalValue] = useDebouncedSearchValue(
onCommit,
EDITOR_SEARCH_RESULT_DEBOUNCE_MS,
);

return (
<Input
Expand All @@ -37,6 +42,8 @@ function DebouncedComponentSearchInput({
export function ComponentSearchV2Content() {
const deepAiSearchEnabled = useFlagValue("component-search-v2-deep-ai");
const [query, setQuery] = useState("");
const deferredQuery = useDeferredValue(query);
const [, startSearchTransition] = useTransition();
const {
results,
browseFolders,
Expand All @@ -48,10 +55,10 @@ export function ComponentSearchV2Content() {
rerank,
deepRerank,
clearRerank,
} = useComponentSearchV2State(query);
} = useComponentSearchV2State(deferredQuery);

const handleQueryCommit = (value: string) => {
setQuery(value);
startSearchTransition(() => setQuery(value));
};

return (
Expand Down Expand Up @@ -112,7 +119,7 @@ export function ComponentSearchV2Content() {
</InlineStack>
</BlockStack>
<ComponentSearchResults
query={query}
query={deferredQuery}
results={results}
browseFolders={browseFolders}
isLoading={isLoading}
Expand Down
Loading