-
-
Notifications
You must be signed in to change notification settings - Fork 268
fix(docs): #9958 TanStack/query make theme toggle keyboard accessible #580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
bharathkumar39293
wants to merge
1,345
commits into
TanStack:main
from
bharathkumar39293:fix/theme-toggle-keyboard-accessibility
Closed
fix(docs): #9958 TanStack/query make theme toggle keyboard accessible #580
bharathkumar39293
wants to merge
1,345
commits into
TanStack:main
from
bharathkumar39293:fix/theme-toggle-keyboard-accessibility
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit bbf390b6917aaf89692dc20d5a4727c5b5970c04
Author: Tanner Linsley <tannerlinsley@gmail.com>
Date: Tue Aug 12 13:34:52 2025 -0600
done
commit fb94aa3b66cad69d3125a1acc5206405ee767b3e
Author: Tanner Linsley <tannerlinsley@gmail.com>
Date: Mon Aug 11 11:26:43 2025 -0600
refactor checkpoint
commit abff5e2 Author: Tanner Linsley <tannerlinsley@gmail.com> Date: Tue Aug 12 19:07:36 2025 -0600 more conflict resolution commit 006fd8c Author: Leonardo Montini <lion.48m@gmail.com> Date: Fri Aug 8 17:32:31 2025 +0200 fix: revert splash afphoto commit 288476c Author: Leonardo Montini <lion.48m@gmail.com> Date: Fri Aug 8 17:30:43 2025 +0200 fix: small menu height commit 931f4d5 Author: Leonardo Montini <lion.48m@gmail.com> Date: Fri Aug 8 17:01:32 2025 +0200 cleanup commit fb3e69d Author: Leonardo Montini <lion.48m@gmail.com> Date: Fri Aug 8 15:57:49 2025 +0200 feat: migrate tailwind config commit abd4027 Author: Leonardo Montini <lion.48m@gmail.com> Date: Fri Aug 8 15:15:39 2025 +0200 feat: update spacings commit ffa0128 Author: Leonardo Montini <lion.48m@gmail.com> Date: Fri Aug 8 13:48:35 2025 +0200 feat: update colors commit 6af1d56 Author: Leonardo Montini <lion.48m@gmail.com> Date: Fri Aug 8 11:58:11 2025 +0200 feat: tailwind migration tool
* Add TanStack.com task tracker with comprehensive marketing and growth tasks Co-authored-by: tannerlinsley <tannerlinsley@gmail.com> * Refactor task list: remove strategic integrations and premium tooling sections Co-authored-by: tannerlinsley <tannerlinsley@gmail.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com>
commit e8b3a81 Author: Tanner Linsley <tannerlinsley@gmail.com> Date: Wed Aug 20 10:05:07 2025 -0600 merge commit b1151bf Author: Austin Montoya <austin@liminal.sh> Date: Tue Aug 19 20:26:44 2025 -0700 add multiple fallbacks commit b175413 Author: Austin Montoya <austin@liminal.sh> Date: Tue Aug 19 20:03:51 2025 -0700 fix image paths commit 1c37e83 Author: Austin Montoya <austin@liminal.sh> Date: Tue Aug 19 20:02:23 2025 -0700 add unique env var name commit 6ca99b8 Author: Tanner Linsley <tannerlinsley@gmail.com> Date: Tue Aug 19 21:01:14 2025 -0600 merge commit 0a00fd2 Author: Austin Montoya <austin@liminal.sh> Date: Tue Aug 19 19:34:44 2025 -0700 try diff env var commit e70b2ae Author: Austin Montoya <austin@liminal.sh> Date: Tue Aug 19 19:30:54 2025 -0700 fix site url when deploying to netlify commit 9de429d Author: Austin Montoya <austin@liminal.sh> Date: Tue Aug 19 18:49:15 2025 -0700 add node types for netlify deploy commit 404ca80 Author: Tanner Linsley <tannerlinsley@gmail.com> Date: Mon Aug 18 17:51:50 2025 -0600 remove other branch artifcat commit e84cc8f Author: Austin Montoya <126262824+austin-liminal@users.noreply.github.com> Date: Mon Aug 18 16:41:11 2025 -0700 refactor: migrate to convex + better-auth (TanStack#471) * refactor: migrate to convex + better-auth * chore: upgrade to tailwindcss v4 --------- Co-authored-by: Tanner Linsley <tannerlinsley@gmail.com>
* Update external link to open in new tab Add target and rel attributes to external links for security. * ci: apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
add preact to pacer and devtool libraries
* Add new sponsor 'humanizerpro' to gh-sponsor-meta.json * ci: apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Remove experiment script and related text Co-authored-by: Cursor Agent <cursoragent@cursor.com>
* Update DocsCalloutQueryGG.tsx * Update query.$version.index.tsx * Update DocsCalloutQueryGG.tsx
* rm unused imports in components folder * rm unused deps from libraries folder * rm unused imports * rm unused css * rm unused imports in libraries route & fix linting errors and warnings in CookieConsent.tsx * ci: apply automated fixes * lazy load imgs * lazy loading bytes and discord img * lazy loading on admin * revert admin lazy img * lazy load mermaid? * update cdn and cache * fix shiki? * increase netlify build-space * rm unused packages * fix pnpm lock * fix tabs / headings * ci: apply automated fixes --------- Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
👷 Deploy request for tanstack pending review.Visit the deploys page to approve it
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #606
The theme toggle in the docs header was not reachable via keyboard navigation, causing it to be skipped in the tab order and violating WCAG 2.4.3. This change renders the toggle as a semantic button, adds an accessible label, and ensures a visible focus indicator. Verified Tab and Shift+Tab navigation on the docs site.