Skip to content

more edge cases#7793

Draft
Sheraff wants to merge 3 commits into
fix-match-loading-readyfrom
fix-match-loading-ready-2
Draft

more edge cases#7793
Sheraff wants to merge 3 commits into
fix-match-loading-readyfrom
fix-match-loading-ready-2

Conversation

@Sheraff

@Sheraff Sheraff commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@coderabbitai

coderabbitai Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 63f683ed-604f-4dea-aa75-d30c5e4c6205

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-match-loading-ready-2

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

View your CI Pipeline Execution ↗ for commit 8a7bf78

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ❌ Failed 5m 24s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 27s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-11 09:42:54 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

7 package(s) bumped directly, 21 bumped as dependents.

🟩 Patch bumps

Package Version Reason
@tanstack/react-router 1.170.16 → 1.170.17 Changeset
@tanstack/router-core 1.171.13 → 1.171.14 Changeset
@tanstack/router-devtools-core 1.168.0 → 1.168.1 Changeset
@tanstack/solid-router 1.170.16 → 1.170.17 Changeset
@tanstack/start-client-core 1.170.12 → 1.170.13 Changeset
@tanstack/start-server-core 1.169.15 → 1.169.16 Changeset
@tanstack/vue-router 1.170.15 → 1.170.16 Changeset
@tanstack/react-router-devtools 1.167.0 → 1.167.1 Dependent
@tanstack/react-start 1.168.26 → 1.168.27 Dependent
@tanstack/react-start-client 1.168.14 → 1.168.15 Dependent
@tanstack/react-start-rsc 0.1.25 → 0.1.26 Dependent
@tanstack/react-start-server 1.167.20 → 1.167.21 Dependent
@tanstack/router-cli 1.167.17 → 1.167.18 Dependent
@tanstack/router-devtools 1.167.0 → 1.167.1 Dependent
@tanstack/router-generator 1.167.17 → 1.167.18 Dependent
@tanstack/router-plugin 1.168.18 → 1.168.19 Dependent
@tanstack/router-vite-plugin 1.167.18 → 1.167.19 Dependent
@tanstack/solid-router-devtools 1.167.0 → 1.167.1 Dependent
@tanstack/solid-start 1.168.26 → 1.168.27 Dependent
@tanstack/solid-start-client 1.168.14 → 1.168.15 Dependent
@tanstack/solid-start-server 1.167.20 → 1.167.21 Dependent
@tanstack/start-plugin-core 1.171.18 → 1.171.19 Dependent
@tanstack/start-static-server-functions 1.167.17 → 1.167.18 Dependent
@tanstack/start-storage-context 1.167.15 → 1.167.16 Dependent
@tanstack/vue-router-devtools 1.167.0 → 1.167.1 Dependent
@tanstack/vue-start 1.168.25 → 1.168.26 Dependent
@tanstack/vue-start-client 1.167.17 → 1.167.18 Dependent
@tanstack/vue-start-server 1.167.20 → 1.167.21 Dependent

@github-actions

github-actions Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Bundle Size Benchmarks

  • Commit: 5584a85a7bd0
  • Measured at: 2026-07-11T09:38:41.382Z
  • Baseline source: history:a3e24c35a58d
  • Dashboard: bundle-size history
Scenario Current (gzip) Delta vs baseline Initial gzip Raw Brotli Trend
react-router.minimal 88.55 KiB +1.18 KiB (+1.35%) 88.42 KiB 275.91 KiB 77.14 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-router.full 92.28 KiB +1.18 KiB (+1.29%) 92.14 KiB 287.81 KiB 80.34 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-router.minimal 36.37 KiB +826 B (+2.27%) 36.25 KiB 106.63 KiB 32.71 KiB ▁▁▁▁▁▂▂▂▂▂▂█
solid-router.full 41.44 KiB +843 B (+2.03%) 41.31 KiB 121.79 KiB 37.28 KiB ▁▁▁▁▁▂▂▂▂▂▂█
vue-router.minimal 53.83 KiB +779 B (+1.43%) 53.70 KiB 150.60 KiB 48.41 KiB ▁▁▁▁▁▂▂▂▂▂▂█
vue-router.full 59.77 KiB +755 B (+1.25%) 59.64 KiB 169.30 KiB 53.62 KiB ▁▁▁▁▁▂▂▂▂▂▂█
react-start.minimal 103.42 KiB +1.39 KiB (+1.36%) 103.28 KiB 324.62 KiB 89.54 KiB ▁▁▁▁▁▂▂▂▂▂▂█
react-start.deferred-hydration 104.16 KiB +1.40 KiB (+1.36%) 103.30 KiB 325.99 KiB 90.18 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.full 106.84 KiB +1.39 KiB (+1.32%) 106.70 KiB 334.56 KiB 92.49 KiB ▁▁▁▁▁▂▂▂▂▂▂█
react-start.rsbuild.minimal 101.40 KiB +1.66 KiB (+1.66%) 101.23 KiB 320.28 KiB 87.34 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.rsbuild.minimal-iife 101.79 KiB +1.65 KiB (+1.64%) 101.63 KiB 321.21 KiB 87.71 KiB ▁▁▁▁▁▁▁▁▁▁▁█
react-start.rsbuild.full 104.66 KiB +1.69 KiB (+1.65%) 104.49 KiB 330.33 KiB 90.11 KiB ▁▁▁▁▁▁▁▁▁▁▁█
solid-start.minimal 50.66 KiB +974 B (+1.91%) 50.53 KiB 152.98 KiB 44.72 KiB ▁▁▁▁▁▂▂▂▂▂▂█
solid-start.deferred-hydration 53.92 KiB +975 B (+1.80%) 50.59 KiB 161.02 KiB 47.70 KiB ▁▁▁▁▁▂▂▂▂▂▂█
solid-start.full 56.53 KiB +1.02 KiB (+1.83%) 56.40 KiB 170.01 KiB 49.78 KiB ▁▁▁▁▂▂▂▂▂▂▂█
vue-start.minimal 72.05 KiB +940 B (+1.29%) 71.92 KiB 208.05 KiB 63.83 KiB ▁▁▁▁▂▂▂▂▂▂▂█
vue-start.full 76.08 KiB +976 B (+1.27%) 75.95 KiB 220.63 KiB 67.29 KiB ▁▁▁▁▂▂▂▂▂▂▂█

Current gzip tracks all emitted client JS chunks. Initial gzip tracks only the entry/import graph. Trend sparkline is historical current gzip ending with this PR measurement; lower is better.

@pkg-pr-new

pkg-pr-new Bot commented Jul 11, 2026

Copy link
Copy Markdown
More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7793

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7793

@tanstack/eslint-plugin-start

npm i https://pkg.pr.new/@tanstack/eslint-plugin-start@7793

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7793

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7793

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7793

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7793

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7793

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7793

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7793

@tanstack/react-start-rsc

npm i https://pkg.pr.new/@tanstack/react-start-rsc@7793

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7793

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7793

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7793

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7793

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7793

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7793

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7793

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7793

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7793

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7793

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7793

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7793

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7793

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7793

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7793

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7793

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7793

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7793

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7793

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7793

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7793

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7793

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7793

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7793

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7793

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7793

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7793

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7793

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7793

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7793

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7793

commit: 8a7bf78

@codspeed-hq

codspeed-hq Bot commented Jul 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 6 improved benchmarks
❌ 8 regressed benchmarks
✅ 82 untouched benchmarks
🗄️ 48 archived benchmarks run1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation ssr redirect (react) 44.9 ms 52 ms -13.81%
Simulation ssr redirect (solid) 43.8 ms 48.5 ms -9.61%
Simulation ssr redirect (vue) 51.9 ms 57 ms -9.1%
Simulation ssr control-flow unmatched 404 (react) 53.7 ms 57.3 ms -6.2%
Simulation ssr control-flow error 500 (react) 58.4 ms 62 ms -5.84%
Simulation ssr not-found (react) 46.1 ms 48.8 ms -5.49%
Simulation ssr before-load chain (react) 45.6 ms 47.2 ms -3.51%
Simulation client-side navigation loop (vue) 65.9 ms 68.2 ms -3.28%
Simulation ssr rewrite passthrough (solid) 80.2 ms 75.3 ms +6.57%
Simulation ssr rewrite passthrough (react) 49.7 ms 47.3 ms +5.08%
Simulation client-side navigation loop (react) 48.6 ms 46.3 ms +4.82%
Simulation ssr before-load chain (solid) 64.8 ms 62.6 ms +3.61%
Simulation ssr global-mw document (solid) 88.3 ms 85.5 ms +3.3%
Simulation ssr assets linked-css control (solid) 66.7 ms 64.7 ms +3.02%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing fix-match-loading-ready-2 (8a7bf78) with fix-match-loading-ready (9e5200d)

Open in CodSpeed

Footnotes

  1. 48 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

@Sheraff Sheraff force-pushed the fix-match-loading-ready-2 branch from 14590bb to 8a7bf78 Compare July 11, 2026 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant