fix(router-generator): keep dotted pathless layout filenames as one segment#7771
Open
thribhuvan003 wants to merge 1 commit into
Open
Conversation
…egment
layout('pathless.layout.tsx') was splitting the layout id on dots via determineInitialRoutePath, so children mounted under a leaked /layout URL segment. Escape unbracketed dots in virtual layout ids so the pathless segment stays intact.
Fixes TanStack#7761.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
📝 WalkthroughWalkthroughUpdates virtual route generation so dotted pathless layout IDs remain single segments, and adds a regression fixture with generated route-tree coverage plus a patch changeset. ChangesVirtual pathless layout path handling
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
virtual layout() with a dotted filename like pathless.layout.tsx was turning the layout id into /_pathless/layout, so kids got mounted under a real /layout URL segment instead of staying at /subpath. dots in layout ids are part of the filename, not path separators - escape them before determineInitialRoutePath so the id stays one pathless segment. generator fixture covers it (fullPaths stays / and /subpath).
Fixes #7761.
Summary by CodeRabbit
Bug Fixes
Tests