WIP: Upgrade to solidjs beta.12 by brenelz · Pull Request #7415 · TanStack/router

brenelz · 2026-05-16T17:13:39Z

No description provided.

coderabbitai · 2026-05-16T17:13:47Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d50ea6bd-ffe3-4819-9ebd-099fda2d6f87

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch upgrade-to-veta.11

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

socket-security · 2026-05-16T17:17:31Z

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert (click "▶" to expand/collapse)
Warn		Obfuscated code: npm `babel-plugin-jsx-dom-expressions` is 91.0% likely obfuscated Confidence: 0.91 Location: Package overview From: pnpm-lock.yaml → `npm/vite-plugin-solid@3.0.0-next.5` → `npm/babel-preset-solid@2.0.0-beta.12` → `npm/babel-plugin-jsx-dom-expressions@0.50.0-next.10` ℹ Read more on: This package \| This alert \| What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at `support@socket.dev`. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment `@SocketSecurity ignore npm/babel-plugin-jsx-dom-expressions@0.50.0-next.10`. You can also ignore all packages with `@SocketSecurity ignore-all`. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

nx-cloud · 2026-05-16T18:09:21Z

View your CI Pipeline Execution ↗ for commit 927fa5a

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	❌ Failed	6m 52s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	39s	View ↗

☁️ Nx Cloud last updated this comment at 2026-05-18 20:16:31 UTC

github-actions · 2026-05-16T18:09:38Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

github-actions · 2026-05-16T18:11:28Z

Bundle Size Benchmarks

Commit: 2bb1e222dce7
Measured at: 2026-05-18T20:10:38.556Z
Baseline source: history:ee8a6753da78
Dashboard: bundle-size history

Scenario	Current (gzip)	Delta vs baseline	Raw	Brotli	Trend
`react-router.minimal`	87.48 KiB	+163 B (+0.18%)	275.76 KiB	75.97 KiB	▁▁▁▂▂▂▂▂▂▂▂█
`react-router.full`	90.78 KiB	-80 B (-0.09%)	286.95 KiB	78.95 KiB	▅▅▅████████▁
`solid-router.minimal`	41.92 KiB	+6.37 KiB (+17.93%)	123.57 KiB	37.85 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`solid-router.full`	46.45 KiB	+6.19 KiB (+15.37%)	137.38 KiB	41.89 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`vue-router.minimal`	53.38 KiB	+60 B (+0.11%)	153.07 KiB	47.94 KiB	▁▁▁▄▄▄▄▄▄▄▄█
`vue-router.full`	58.25 KiB	-205 B (-0.34%)	168.53 KiB	52.18 KiB	▇▇▇████████▁
`react-start.minimal`	102.01 KiB	-2 B (-0.00%)	324.00 KiB	88.21 KiB	▁▁▁█████████
`react-start.full`	105.38 KiB	-61 B (-0.06%)	334.35 KiB	91.14 KiB	▄▄▄████████▁
`solid-start.minimal`	63.09 KiB	+13.43 KiB (+27.04%)	191.97 KiB	55.81 KiB	▁▁▁▁▁▁▁▁▁▁▁█
`solid-start.full`	66.99 KiB	+11.56 KiB (+20.84%)	203.50 KiB	59.20 KiB	▁▁▁▁▁▁▁▁▁▁▁█

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

pkg-pr-new · 2026-05-16T18:12:49Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@7415

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@7415

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@7415

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@7415

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@7415

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@7415

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@7415

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@7415

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@7415

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@7415

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@7415

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@7415

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@7415

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@7415

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@7415

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@7415

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@7415

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@7415

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@7415

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@7415

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@7415

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@7415

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@7415

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@7415

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@7415

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@7415

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@7415

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@7415

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@7415

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@7415

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@7415

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@7415

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@7415

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@7415

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@7415

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@7415

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@7415

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@7415

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@7415

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@7415

commit: 4e2a2db

codspeed-hq · 2026-05-16T18:26:25Z

Merging this PR will improve performance by 63.33%

⚡ 2 improved benchmarks
✅ 4 untouched benchmarks

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	`ssr request loop (solid)`	174.6 ms	103.5 ms	+68.72%
⚡	`client-side navigation loop (solid)`	72.6 ms	45.9 ms	+58.11%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing upgrade-to-veta.11 (4e2a2db) with solid-router-v2-pre (67a9040)¹}

No successful run was found on solid-router-v2-pre (1cd6afb) during the generation of this report, so 67a9040 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

nx-cloud

Important

At least one additional CI pipeline execution has run since the conclusion below was written and it may no longer be applicable.

Nx Cloud is proposing a fix for your failed CI:

We fixed a cache-corruption bug introduced by the new matchedRoutesCache in router-core/src/router.ts. The cached routeParams object was being mutated in-place by Object.assign(routeParams, strictParams) in matchRoute, causing subsequent cache hits to return already-parsed params (e.g. { postId: '2', status: 'parsed' }) as the raw input to parseParams instead of the original URL params ({ postId: '2' }). Returning a fresh copy of routeParams on cache hits prevents this mutation from propagating back into the cache, fixing the failing unit tests across @tanstack/react-router, @tanstack/vue-router, and @tanstack/solid-router.

Tip

✅ We verified this fix by re-running @tanstack/react-router:test:unit, @tanstack/solid-router:test:unit, @tanstack/vue-router:test:unit.

Warning

The suggested diff is too large to display here, but you can view it on Nx Cloud ↗

Or Apply changes locally with:

npx nx-cloud apply-locally yJni-iCyH

Apply fix locally with your editor ↗ View interactive diff ↗

_{🎓 Learn more about Self-Healing CI on nx.dev}

This reverts commit 2087f9a.

This reverts commit 87c86cb.

socket-security · 2026-05-18T19:17:32Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Package	Supply Chain Security	Quality	Maintenance
@solidjs/web@2.0.0-beta.10 ⏵ 2.0.0-beta.12	⁺¹	⁺¹	⁺²
babel-preset-solid@2.0.0-beta.12
solid-js@2.0.0-beta.10 ⏵ 2.0.0-beta.12	⁺¹	⁺¹	⁺²

View full report

brenelz added 3 commits May 11, 2026 19:40

chore: bump to solid v2 beta 11

c1d15fe

chore: bump to solid v2 beta 12

c75af9d

chore: update For loop item accessors for solid v2 beta 11

7523dd8

brenelz changed the title ~~WIP: Upgrade to veta.11~~ WIP: Upgrade to beta.12 May 16, 2026

brenelz changed the title ~~WIP: Upgrade to beta.12~~ WIP: Upgrade to solidjs beta.12 May 16, 2026

chore: copy over github workflow changes

fd619e2

github-actions Bot added package: solid-router package: solid-start-client package: solid-start-server package: solid-start package: solid-router-devtools package: solid-router-ssr-query labels May 16, 2026

This comment was marked as outdated.

Sign in to view

chore: copy over github workflow changes [Self-Healing CI Rerun]

1da6b22

brenelz added 2 commits May 16, 2026 16:03

test: play with benchmarks

87c86cb

test: play with benchmarks again

2087f9a

github-actions Bot added the package: router-core label May 17, 2026

nx-cloud Bot reviewed May 17, 2026

View reviewed changes

brenelz added 2 commits May 18, 2026 14:04

Revert "test: play with benchmarks again"

458a5ec

This reverts commit 2087f9a.

Revert "test: play with benchmarks"

fd613fa

This reverts commit 87c86cb.

brenelz added 2 commits May 18, 2026 14:43

test: speedup ssr for solid

927fa5a

test: play with client side benchmark

4e2a2db

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

WIP: Upgrade to solidjs beta.12#7415

WIP: Upgrade to solidjs beta.12#7415
brenelz wants to merge 11 commits into
solid-router-v2-prefrom
upgrade-to-veta.11

brenelz commented May 16, 2026

Uh oh!

coderabbitai Bot commented May 16, 2026 •

edited

Loading

Review skipped

Uh oh!

socket-security Bot commented May 16, 2026 •

edited

Loading

Uh oh!

nx-cloud Bot commented May 16, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 16, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 16, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented May 16, 2026 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

codspeed-hq Bot commented May 16, 2026 •

edited

Loading

Uh oh!

nx-cloud Bot left a comment •

edited

Loading

Uh oh!

socket-security Bot commented May 18, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

brenelz commented May 16, 2026

Uh oh!

coderabbitai Bot commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

socket-security Bot commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nx-cloud Bot commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🚀 Changeset Version Preview

Uh oh!

github-actions Bot commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Size Benchmarks

Uh oh!

pkg-pr-new Bot commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

codspeed-hq Bot commented May 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 63.33%

Performance Changes

Footnotes

Uh oh!

nx-cloud Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Nx Cloud is proposing a fix for your failed CI:

Uh oh!

socket-security Bot commented May 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai Bot commented May 16, 2026 •

edited

Loading

socket-security Bot commented May 16, 2026 •

edited

Loading

nx-cloud Bot commented May 16, 2026 •

edited

Loading

github-actions Bot commented May 16, 2026 •

edited

Loading

github-actions Bot commented May 16, 2026 •

edited

Loading

pkg-pr-new Bot commented May 16, 2026 •

edited

Loading

codspeed-hq Bot commented May 16, 2026 •

edited

Loading

nx-cloud Bot left a comment •

edited

Loading

socket-security Bot commented May 18, 2026 •

edited

Loading