Skip to content

fix: add missing router-core peer dependency to ssr-query packages #6382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SeoJaeWan wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −0
Open

fix: add missing router-core peer dependency to ssr-query packages #6382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9643b7f
fix: add missing router-core peer dependency to ssr-query packages
SeoJaeWan Jan 13, 2026
f75fc0f
chore: update pnpm-lock.yaml
SeoJaeWan Jan 16, 2026
dcc60fc
Merge branch 'main' into fix/ssr-query-router-core-peer-dependency
SeoJaeWan Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/react-router-ssr-query/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
"react": ">=18.0.0 || >=19.0.0",
"react-dom": ">=18.0.0 || >=19.0.0",
"@tanstack/query-core": ">=5.90.0",
"@tanstack/router-core": ">=1.127.0",
"@tanstack/react-router": ">=1.127.0",
"@tanstack/react-query": ">=5.90.0"
}
Expand Down
1 change: 1 addition & 0 deletions packages/solid-router-ssr-query/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
},
"peerDependencies": {
"@tanstack/query-core": ">=5.90.0",
"@tanstack/router-core": ">=1.127.0",
"@tanstack/solid-query": ">=5.90.0",
Comment on lines 76 to 79
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# Find the location of `@tanstack/router-core` package
find . -type f -name "package.json" -path "*/router-core/*" | head -5

Repository: TanStack/router

Length of output: 94

🏁 Script executed:

# Check the file in question and its full content
cat packages/solid-router-ssr-query/package.json

Repository: TanStack/router

Length of output: 2472

🏁 Script executed:

# Search for how other packages define peerDependencies with internal packages
rg -A 3 '"peerDependencies"' --type json | head -100

Repository: TanStack/router

Length of output: 5238

Use workspace:* for internal peer dependencies.

@tanstack/router-core is an internal monorepo package and should use the workspace protocol. This aligns with the workspace protocol requirement for package.json entries and matches the pattern used in similar packages like @tanstack/solid-router-devtools and @tanstack/vue-router-devtools.

🔧 Suggested change 
-    "@tanstack/router-core": ">=1.127.0",
+    "@tanstack/router-core": "workspace:*",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"peerDependencies": {
"@tanstack/query-core": ">=5.90.0",
"@tanstack/router-core": ">=1.127.0",
"@tanstack/solid-query": ">=5.90.0",
"peerDependencies": {
"@tanstack/query-core": ">=5.90.0",
"@tanstack/router-core": "workspace:*",
"@tanstack/solid-query": ">=5.90.0",
🤖 Prompt for AI Agents 
In `@packages/solid-router-ssr-query/package.json` around lines 76 - 79, Update
the peerDependencies entry for the internal monorepo package by replacing the
version constraint for "@tanstack/router-core" with the workspace protocol;
locate the peerDependencies object in package.json (the entry for
"@tanstack/router-core") and change its value to "workspace:*" so it matches
other internal packages like `@tanstack/solid-router-devtools`.

"@tanstack/solid-router": ">=1.127.0",
"solid-js": "^1.9.10"
Expand Down
1 change: 1 addition & 0 deletions packages/vue-router-ssr-query/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
},
"peerDependencies": {
"@tanstack/query-core": ">=5.90.0",
"@tanstack/router-core": ">=1.127.0",
"@tanstack/vue-query": ">=5.90.0",
Comment on lines 70 to 73
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

# First, find the package.json file and see its context
find . -name "package.json" -type f | head -20

Repository: TanStack/router

Length of output: 1158

🏁 Script executed:

# Check the specific file mentioned in the review
cat packages/vue-router-ssr-query/package.json | head -80

Repository: TanStack/router

Length of output: 2262

🏁 Script executed:

# Look for other package.json files in the packages directory to see how internal deps are handled
find packages -name "package.json" -type f | xargs grep -l "@tanstack/router-core" | head -10

Repository: TanStack/router

Length of output: 460

🏁 Script executed:

# Check if workspace:* is used for internal dependencies in other package.json files
rg '"@tanstack/[^"]+": "workspace:\*' packages --type json

Repository: TanStack/router

Length of output: 7838

🏁 Script executed:

# Search for workspace:* in peerDependencies sections
rg -A 20 '"peerDependencies"' packages --type json | grep -E '(peerDependencies|workspace:\*|@tanstack)'

Repository: TanStack/router

Length of output: 5257

🏁 Script executed:

# Check specific examples of internal packages' peerDependencies to see the pattern
cat packages/react-router-ssr-query/package.json | grep -A 10 '"peerDependencies"'

Repository: TanStack/router

Length of output: 331

🏁 Script executed:

# Check vue-router's peerDependencies as well
cat packages/vue-router/package.json | grep -A 10 '"peerDependencies"'

Repository: TanStack/router

Length of output: 108

🏁 Script executed:

# Check the most similar packages to vue-router-ssr-query (other devtools packages)
echo "=== Vue Router Devtools peerDependencies ===" && \
cat packages/vue-router-devtools/package.json | grep -A 5 '"peerDependencies"'

echo "=== React Router Devtools peerDependencies ===" && \
cat packages/react-router-devtools/package.json | grep -A 5 '"peerDependencies"'

echo "=== Router Devtools Core peerDependencies ===" && \
cat packages/router-devtools-core/package.json | grep -A 5 '"peerDependencies"'

Repository: TanStack/router

Length of output: 699

🏁 Script executed:

# Check if there's a pattern: when was workspace:^ introduced vs version constraints
# Look at start-static-server-functions which uses workspace:* in peerDependencies
cat packages/start-static-server-functions/package.json | grep -A 10 '"peerDependencies"'

Repository: TanStack/router

Length of output: 323

🏁 Script executed:

# Check if there's a distinction between how workspace:* vs workspace:^ is used
# across different types of internal packages
rg '"workspace:\^"' packages --type json | head -20

Repository: TanStack/router

Length of output: 913

🏁 Script executed:

# See if there's any documentation or pattern in the repo about this choice
find . -name "CONTRIBUTING*" -o -name "README*" | xargs grep -l "workspace" 2>/dev/null | head -5

Repository: TanStack/router

Length of output: 76

🏁 Script executed:

# Check CONTRIBUTING.md for workspace protocol guidance
cat CONTRIBUTING.md | grep -A 5 -B 5 "workspace"

Repository: TanStack/router

Length of output: 634

Use workspace:* for the internal peer dependency.

@tanstack/router-core is an internal monorepo package and should use the workspace protocol to maintain consistency with the codebase standards and enable proper local linking.

🔧 Suggested change 
-    "@tanstack/router-core": ">=1.127.0",
+    "@tanstack/router-core": "workspace:*",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"peerDependencies": {
"@tanstack/query-core": ">=5.90.0",
"@tanstack/router-core": ">=1.127.0",
"@tanstack/vue-query": ">=5.90.0",
"peerDependencies": {
"@tanstack/query-core": ">=5.90.0",
"@tanstack/router-core": "workspace:*",
"@tanstack/vue-query": ">=5.90.0",
🤖 Prompt for AI Agents 
In `@packages/vue-router-ssr-query/package.json` around lines 70 - 73, Update the
peerDependencies entry for the internal monorepo package by replacing the
version specifier for "@tanstack/router-core" with the workspace protocol; edit
the package.json peerDependencies block where "@tanstack/router-core" is listed
and change its value to "workspace:*" so the package uses the monorepo workspace
link instead of a hard version string.

"@tanstack/vue-router": ">=1.127.0",
"vue": "^3.3.0"
Expand Down
9 changes: 9 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.