chore(*): declare '@eslint-react/eslint-plugin' in the react packages and examples that use it instead of the root by sukvvon · Pull Request #11726 · TanStack/query

sukvvon · 2026-09-29T02:41:23Z

🎯 Changes

Remove @eslint-react/eslint-plugin (^5.21.0) from the root devDependencies.
Declare it in the devDependencies of the packages and examples whose eslint.config.js imports it:
- react-query, react-query-devtools, react-query-next-experimental, react-query-persist-client
- examples/react/algolia, examples/react/basic, examples/react/basic-graphql-request, examples/react/batching, examples/react/shadow-dom
Update pnpm-lock.yaml. No new packages or versions; the plugin now resolves its typescript peer from each project, so the examples use their own TypeScript version instead of the root one.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores
- Updated development tooling configuration across React examples and packages, aligning linting setup with the projects that use it. These changes affect development workflows only; application behavior and public APIs remain unchanged. No new end-user features or fixes are included in this update.

… and examples that use it instead of the root

nx-cloud · 2026-09-29T02:41:51Z

View your CI Pipeline Execution ↗ for commit 7a5a505

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	7m 45s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	35s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-29 02:50:18 UTC

github-actions · 2026-09-29T02:42:27Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-09-29T02:43:37Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11726

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11726

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11726

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11726

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11726

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11726

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11726

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11726

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11726

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11726

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11726

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11726

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11726

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11726

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11726

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11726

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11726

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11726

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11726

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11726

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11726

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11726

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11726

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11726

commit: 7a5a505

coderabbitai · 2026-09-29T02:43:59Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 3a8d6283-44f2-47df-84dd-fa1a28b9508d

📥 Commits

Reviewing files that changed from the base of the PR and between a914613 and 7a5a505.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (10)

examples/react/algolia/package.json
examples/react/basic-graphql-request/package.json
examples/react/basic/package.json
examples/react/batching/package.json
examples/react/shadow-dom/package.json
package.json
packages/react-query-devtools/package.json
packages/react-query-next-experimental/package.json
packages/react-query-persist-client/package.json
packages/react-query/package.json

💤 Files with no reviewable changes (1)

package.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

📝 Walkthrough

Walkthrough

The root development dependencies no longer include @eslint-react/eslint-plugin. Five React examples and four React Query packages now declare it as a development dependency at version ^5.21.0.

Changes

Dependency placement

Layer / File(s)	Summary
Update development dependency manifests `package.json`, `packages/react-query-/package.json`, `examples/react//package.json`	The root manifest removes `@eslint-react/eslint-plugin`. Four React Query packages and five React examples add it to `devDependencies` at version `^5.21.0`.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Suggested reviewers: lachlancollins

Merge Risk: ⚪ Minimal · up to 7a5a5

The dependency move preserves plugin resolution for the affected ESLint configurations, with no identified merge-blocking risk.

Architecture Summary

Architecture risk: 🔵 Low · up to 7a5a5

The change affects 6 systems.

Changed systems: examples, package.json, packages/react-query, packages/react-query-devtools, packages/react-query-next-experimental, packages/react-query-persist-client

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — examples (service) was modified; 5 changed files map to changed impact.
observed — package.json (service) was modified; 1 changed file maps to changed impact.
observed — packages/react-query (library) was modified; 1 changed file maps to changed impact.
observed — packages/react-query-devtools (library) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in examples/react/algolia/package.json: Added @eslint-react/eslint-plugin (^5.21.0) as a dev dependency.
observed — Modified behavior in examples/react/basic-graphql-request/package.json: Added @eslint-react/eslint-plugin (^5.21.0) to devDependencies.
observed — Modified behavior in examples/react/basic/package.json: Added @eslint-react/eslint-plugin version ^5.21.0 to devDependencies.
observed — Modified behavior in examples/react/batching/package.json: Added @eslint-react/eslint-plugin at version ^5.21.0 to the dev dependencies.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: moving `@eslint-react/eslint-plugin` from the root development dependencies to the React packages and examples that use it.
Description check	✅ Passed	The description includes the required Changes, Checklist, and Release Impact sections. It explains the dependency move, lockfile update, testing status, contribution policy, and lack of release impact…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-29T02:44:40Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

chore(*): declare '@eslint-react/eslint-plugin' in the react packages…

7a5a505

… and examples that use it instead of the root

sukvvon self-assigned this Sep 29, 2026

sukvvon merged commit c51bb62 into main Sep 29, 2026
9 checks passed

sukvvon deleted the chore/eslint-react-plugin-per-package branch September 29, 2026 02:56

Navigation Menu

Uh oh!

chore(*): declare '@eslint-react/eslint-plugin' in the react packages and examples that use it instead of the root - #11726

chore(*): declare '@eslint-react/eslint-plugin' in the react packages and examples that use it instead of the root#11726
sukvvon merged 1 commit into
mainfrom
chore/eslint-react-plugin-per-package

sukvvon commented Sep 29, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Sep 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 29, 2026

Uh oh!

pkg-pr-new Bot commented Sep 29, 2026

Uh oh!

coderabbitai Bot commented Sep 29, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

github-actions Bot commented Sep 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Sep 29, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 29, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new Bot commented Sep 29, 2026

Uh oh!

coderabbitai Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Architecture Summary

Uh oh!

github-actions Bot commented Sep 29, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 29, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Sep 29, 2026 •

edited

Loading

coderabbitai Bot commented Sep 29, 2026 •

edited

Loading