chore(*): declare 'eslint-plugin-react-hooks' in the react packages that use it instead of the root by sukvvon · Pull Request #11725 · TanStack/query

sukvvon · 2026-09-29T02:20:07Z

🎯 Changes

Move eslint-plugin-react-hooks (^7.1.1) from the root devDependencies to the devDependencies of react-query, react-query-devtools, react-query-next-experimental, and react-query-persist-client, which are the only packages whose eslint.config.js imports it.
Update pnpm-lock.yaml (deduped so the plugin keeps a single peer variant; no new packages or versions).

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores
- Updated development tooling configuration across several packages. No user-facing behavior changes are included.

…hat use it instead of the root

nx-cloud · 2026-09-29T02:20:33Z

View your CI Pipeline Execution ↗ for commit c7bb2e8

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	7m 48s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	35s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-29 02:29:03 UTC

github-actions · 2026-09-29T02:21:09Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-09-29T02:22:03Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: af3495ab-2c14-4ad1-9e25-aa261b26134e

📥 Commits

Reviewing files that changed from the base of the PR and between 31dc60f and c7bb2e8.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (5)

package.json
packages/react-query-devtools/package.json
packages/react-query-next-experimental/package.json
packages/react-query-persist-client/package.json
packages/react-query/package.json

💤 Files with no reviewable changes (1)

package.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

📝 Walkthrough

Walkthrough

The root manifest no longer lists eslint-plugin-react-hooks as a development dependency. Four package manifests now list version ^7.1.1 as a development dependency.

Changes

Development dependency scope

Layer / File(s)	Summary
Set package-level plugin dependencies `package.json`, `packages/react-query-devtools/package.json`, `packages/react-query-next-experimental/package.json`, `packages/react-query-persist-client/package.json`, `packages/react-query/package.json`	The root manifest removes `eslint-plugin-react-hooks`. The four package manifests add version `^7.1.1` to their development dependencies.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested reviewers: lachlancollins

Merge Risk: ⚪ Minimal · up to c7bb2

The checked-in lint and build workflows retain the plugin where they need it, and the lockfile matches the dependency changes. No supported workflow failure was identified.

Architecture Summary

Architecture risk: 🔵 Low · up to c7bb2

The change affects 5 systems.

Changed systems: package.json, packages/react-query, packages/react-query-devtools, packages/react-query-next-experimental, packages/react-query-persist-client

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — package.json (service) was modified; 1 changed file maps to changed impact.
observed — packages/react-query (library) was modified; 1 changed file maps to changed impact.
observed — packages/react-query-devtools (library) was modified; 1 changed file maps to changed impact.
observed — packages/react-query-next-experimental (library) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in package.json: Removed eslint-plugin-react-hooks from the root devDependencies.
observed — Modified behavior in packages/react-query-devtools/package.json: Added eslint-plugin-react-hooks at version ^7.1.1 to devDependencies.
observed — Modified behavior in packages/react-query-next-experimental/package.json: Added eslint-plugin-react-hooks at version ^7.1.1 to devDependencies.
observed — Modified behavior in packages/react-query-persist-client/package.json: Added eslint-plugin-react-hooks at version ^7.1.1 to devDependencies.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the dependency move from the root package to the React packages that use it.
Description check	✅ Passed	The description follows the required template, explains the dependency move and lockfile update, completes the checklist, and identifies the change as development-only with no release required.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-09-29T02:22:20Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11725

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11725

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11725

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11725

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11725

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11725

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11725

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11725

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11725

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11725

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11725

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11725

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11725

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11725

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11725

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11725

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11725

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11725

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11725

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11725

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11725

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11725

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11725

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11725

commit: c7bb2e8

github-actions · 2026-09-29T02:23:20Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

chore(*): declare 'eslint-plugin-react-hooks' in the react packages t…

c7bb2e8

…hat use it instead of the root

sukvvon self-assigned this Sep 29, 2026

sukvvon merged commit a914613 into main Sep 29, 2026
9 checks passed

sukvvon deleted the chore/react-hooks-eslint-plugin-per-package branch September 29, 2026 02:37

Navigation Menu

Uh oh!

chore(*): declare 'eslint-plugin-react-hooks' in the react packages that use it instead of the root - #11725

chore(*): declare 'eslint-plugin-react-hooks' in the react packages that use it instead of the root#11725
sukvvon merged 1 commit into
mainfrom
chore/react-hooks-eslint-plugin-per-package

sukvvon commented Sep 29, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Sep 29, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 29, 2026

Uh oh!

coderabbitai Bot commented Sep 29, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 29, 2026

Uh oh!

github-actions Bot commented Sep 29, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Sep 29, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 29, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Architecture Summary

Uh oh!

pkg-pr-new Bot commented Sep 29, 2026

Uh oh!

github-actions Bot commented Sep 29, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 29, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Sep 29, 2026 •

edited

Loading

coderabbitai Bot commented Sep 29, 2026 •

edited

Loading