fix(lit-query): migrate to standard tsup build so 'build' output is cached by nx and 'test:build' passes#10943
Open
sukvvon wants to merge 4 commits into
Open
fix(lit-query): migrate to standard tsup build so 'build' output is cached by nx and 'test:build' passes#10943sukvvon wants to merge 4 commits into
sukvvon wants to merge 4 commits into
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughMigrates Changeslit-query tsup build migration
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
🚀 Changeset Version Preview1 package(s) bumped directly, 0 bumped as dependents. 🟩 Patch bumps
|
|
View your CI Pipeline Execution ↗ for commit edc4b75
☁️ Nx Cloud last updated this comment at |
Contributor
size-limit report 📦
|
sukvvon
force-pushed
the
fix/lit-query-standard-tsup-build
branch
from
22891f4 to
703f2f7
Compare
…ached by nx and 'test:build' passes
sukvvon
force-pushed
the
fix/lit-query-standard-tsup-build
branch
from
703f2f7 to
5dae012
Compare
…to 'vite.config.ts' to match react-query, drop obsolete knip 'src/tests' ignore
sukvvon
force-pushed
the
fix/lit-query-standard-tsup-build
branch
from
0dac11a to
f8f010c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
lit-query was the only package building with a non-standard
tsctwo-pass setup (dist/ESM +dist-cjs/CJS viabuild:cjs+write-cjs-package.mjs). Itsdist-cjs/output is not part of nx'sbuild.outputs({projectRoot}/build,{projectRoot}/dist), so on a CI cache-hitdist-cjs/is not restored andpublint --strictfails withdist-cjs/index.js does not exist, breaking@tanstack/lit-query:test:build.This migrates lit-query to the standard
tsupbuild used by the other adapters (react-query as the reference), producing a singlebuild/directory (build/modern+build/legacy, each with.js/.cjs/.d.ts/.d.cts).build/is already in nx'sbuild.outputs, so the cache-hit failure is resolved without touchingnx.json. While here, the rest of the package config is aligned with react-query for consistency.Build migration:
tsup.config.tsandtsconfig.prod.json, and addroot.tsup.config.jsas a symlink to the sharedscripts/getTsupConfig.js(matching every other adapter).tsconfig.jsonto extend the root config (drop the per-packageNodeNextoverride).package.json:build→tsup --tsconfig tsconfig.prod.json, pointmain/module/types/exports/filesatbuild/, drop thetest:buildcjs-smoke step.tsconfig.build.json,tsconfig.build.cjs.json,scripts/write-cjs-package.mjs,scripts/check-cjs-types-smoke.mjs.eslint.config.jsignores and the perf scripts atbuild/, and drop the staledist-cjsentry from.gitignore.Config alignment with react-query:
package.jsonfields (scripts block first, thentype/types/main/module/exports/sideEffects/files/deps).cleanalso removes./dist-ts,compile→tsc --build,test:types→tsc --noEmit,test:eslint/lint:fixuse--concurrency=auto,test:lib→vitest,test:lib:dev→pnpm run test:lib --watch. lit-specific scripts (measure:bundle*,perf:l3*,test:watch) are kept.vitest.config.ts→vite.config.tsand addtest.nameplus the standardistanbulcoverage block (enabled on CI).packages/lit-querysrc/testsignore from the rootknip.json(the renamedvite.config.tslets knip detect the test entry automatically, like the other adapters).Runtime output is unchanged: the named exports are identical (52),
attwpasses on node10/node16 (CJS/ESM)/bundler, andpublint --strictreportsAll good!.✅ Checklist
pnpm run test:pr.🚀 Release Impact
Summary by CodeRabbit
tsupsetup to improve build caching and overall build reliability.buildartifacts.test:buildis more likely to pass after clean builds.@tanstack/lit-querypatch bump.