Skip to content

fix(solid-query): strip promise field in hydratableObserverResult to … #10104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
erikrahm wants to merge 2 commits into
base: main
Choose a base branch
from
+8 −2
Open

fix(solid-query): strip promise field in hydratableObserverResult to … #10104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6af9a1d
fix(solid-query): strip promise field in hydratableObserverResult to …
erikrahm Feb 8, 2026
6b3f382
chore: add changeset for solid-query SSR promise fix
erikrahm Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/curly-places-train.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/solid-query': patch
---

fix(solid-query): prevent SSR stream hang caused by unstripped promise field
5 changes: 3 additions & 2 deletions packages/solid-query/src/useBaseQuery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,9 +76,10 @@ const hydratableObserverResult = <
if (!isServer) return result
const obj: any = {
...unwrap(result),
// During SSR, functions cannot be serialized, so we need to remove them
// This is safe because we will add these functions back when the query is hydrated
// During SSR, non-serializable values (functions, promises) must be removed.
// This is safe because they will be reconstructed when the query is hydrated.
refetch: undefined,
promise: undefined,
}

// If the query is an infinite query, we need to remove additional properties
Expand Down