Skip to content

fix(form-core): clear stale onMount error on linked-field revalidation #2136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mixelburg wants to merge 1 commit into
base: main
Choose a base branch
from
+34 −14
Open

fix(form-core): clear stale onMount error on linked-field revalidation #2136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 34 additions & 14 deletions packages/form-core/src/FieldApi.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1735,17 +1735,28 @@ export class FieldApi<

// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
if (field.state.meta.errorMap?.[errorMapKey] !== newErrorValue) {
field.setMeta((prev) => ({
...prev,
errorMap: {
field.setMeta((prev) => {
const nextErrorMap = {
...prev.errorMap,
[errorMapKey]: newErrorValue,
},
errorSourceMap: {
...prev.errorSourceMap,
[errorMapKey]: newSource,
},
}))
}
// Clear stale onMount error when a later validator confirms the field is valid
if (
!newErrorValue &&
errorMapKey !== 'onMount' &&
prev.errorMap.onMount
) {
nextErrorMap.onMount = undefined
}
return {
...prev,
errorMap: nextErrorMap,
errorSourceMap: {
...prev.errorSourceMap,
[errorMapKey]: newSource,
},
}
})
Comment on lines +1738 to +1759
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Clear errorSourceMap.onMount to maintain consistency with errorMap.onMount.

When clearing errorMap.onMount, the corresponding errorSourceMap.onMount entry should also be cleared to keep the two maps in sync. The existing submit error clearing logic (lines 1787-1797) clears both maps, establishing this pattern.

Additionally, use optional chaining (prev.errorMap?.onMount) at line 1747 for defensive consistency with line 1737.

🔧 Proposed fix to clear errorSourceMap.onMount 
         field.setMeta((prev) => {
           const nextErrorMap = {
             ...prev.errorMap,
             [errorMapKey]: newErrorValue,
           }
+          const nextErrorSourceMap = {
+            ...prev.errorSourceMap,
+            [errorMapKey]: newSource,
+          }
           // Clear stale onMount error when a later validator confirms the field is valid
           if (
             !newErrorValue &&
             errorMapKey !== 'onMount' &&
-            prev.errorMap.onMount
+            prev.errorMap?.onMount
           ) {
             nextErrorMap.onMount = undefined
+            nextErrorSourceMap.onMount = undefined
           }
           return {
             ...prev,
             errorMap: nextErrorMap,
-            errorSourceMap: {
-              ...prev.errorSourceMap,
-              [errorMapKey]: newSource,
-            },
+            errorSourceMap: nextErrorSourceMap,
           }
         })
🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@packages/form-core/src/FieldApi.ts` around lines 1738 - 1759, In
field.setMeta's updater (the block handling nextErrorMap), when you detect
clearing a stale onMount error (the if that checks !newErrorValue && errorMapKey
!== 'onMount' && prev.errorMap.onMount), also clear the corresponding entry in
errorSourceMap (set nextErrorSourceMap.onMount = undefined or ensure the
returned errorSourceMap has onMount removed) so errorMap and errorSourceMap stay
in sync; additionally change the check to use optional chaining
(prev.errorMap?.onMount) for defensive access. Reference: the field.setMeta
updater, variables errorMapKey, newErrorValue, newSource, and errorSourceMap in
this diff.

}
if (newErrorValue) {
hasErrored = true
Expand Down Expand Up @@ -1934,13 +1945,22 @@ export class FieldApi<
}

field.setMeta((prev) => {
const nextErrorMap = {
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
...prev?.errorMap,
[errorMapKey]: newErrorValue,
}
// Clear stale onMount error when a later validator confirms the field is valid
if (
!newErrorValue &&
errorMapKey !== 'onMount' &&
prev.errorMap.onMount
) {
nextErrorMap.onMount = undefined
}
return {
...prev,
errorMap: {
// eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
...prev?.errorMap,
[errorMapKey]: newErrorValue,
},
errorMap: nextErrorMap,
errorSourceMap: {
...prev.errorSourceMap,
[errorMapKey]: newSource,
Expand Down