-
Notifications
You must be signed in to change notification settings - Fork 43
Add axis side placement for right-to-left locales #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| --- | ||
| '@tanstack/charts': minor | ||
| --- | ||
|
|
||
| Add `axis.side` so an axis can sit on the opposite plot edge, moving its stubs, | ||
| tick labels, title, crosshair value label, and automatic margin with it. A | ||
| right-to-left locale reads the value axis on the right through | ||
| `y.axis.side: 'end'`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Correct the RTL
axis.sidedocumentation in both copies.The prose uses
sideas though it were a valid value. Useside: 'end'and hyphenatey-axisandx-axis.docs/concepts/layout-axes-and-coordinates.md#L165-L171: update the source documentation.packages/charts-core/docs/concepts/layout-axes-and-coordinates.md#L165-L171: regenerate the package copy from the corrected source.🧰 Tools
🪛 LanguageTool
[grammar] ~165-~165: Use a hyphen to join words.
Context: ... defaults to
start, which places the y axis left and the x axis bottom.endp...(QB_NEW_EN_HYPHEN)
[grammar] ~165-~165: Use a hyphen to join words.
Context: ..., which places the y axis left and the x axis bottom.
endplaces the y axis rig...(QB_NEW_EN_HYPHEN)
[grammar] ~166-~166: Use a hyphen to join words.
Context: ...nd the x axis bottom.
endplaces the y axis right and the x axis top, and moves...(QB_NEW_EN_HYPHEN)
[grammar] ~166-~166: Use a hyphen to join words.
Context: ...
endplaces the y axis right and the x axis top, and moves that axis's stubs, t...(QB_NEW_EN_HYPHEN)
[grammar] ~171-~171: Use a hyphen to join words.
Context: ... y axis combined with
reverseon the x axis: ```ts const chart = { x: { scal...(QB_NEW_EN_HYPHEN)
📍 Affects 2 files
docs/concepts/layout-axes-and-coordinates.md#L165-L171(this comment)packages/charts-core/docs/concepts/layout-axes-and-coordinates.md#L165-L171🤖 Prompt for AI Agents
Source: Linters/SAST tools