-
-
Notifications
You must be signed in to change notification settings - Fork 312
fix(ai-client): avoid per-chunk stream scheduling delays #1202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kolaworld
wants to merge
7
commits into
TanStack:main
Choose a base branch
from
kolaworld:fix-1193-stream-speed
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
abd0f40
test(ai-client): cover buffered stream scheduling
kolaworld 53855db
perf(ai-client): process stream chunks immediately
kolaworld 6e6a4d6
perf(ai-client): time-slice buffered stream processing
kolaworld fded8a4
perf(ai-client): time-slice joined run replay
kolaworld 9fdc1f1
fix(ai-client): coordinate concurrent stream processing
kolaworld df33672
fix(ai-client): include replay setup in processing budget
kolaworld 8b37553
ci: apply automated fixes
autofix-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@tanstack/ai-client': patch | ||
| --- | ||
|
|
||
| Process live chat chunks without waiting for a separate macrotask after each chunk. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 0 additions & 47 deletions
47
packages/ai-client/tests/chat-client-hidden-tab-yield.test.ts
This file was deleted.
Oops, something went wrong.
140 changes: 140 additions & 0 deletions
140
packages/ai-client/tests/chat-client-stream-processing.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,140 @@ | ||
| import { afterEach, describe, expect, it, vi } from 'vitest' | ||
| import { ChatClient } from '../src/chat-client' | ||
| import { createMockConnectionAdapter, createTextChunks } from './test-utils' | ||
| import type { StreamChunk } from '@tanstack/ai/client' | ||
|
|
||
| afterEach(() => { | ||
| vi.restoreAllMocks() | ||
| vi.unstubAllGlobals() | ||
| }) | ||
|
|
||
| describe('ChatClient stream processing', () => { | ||
| it('does not wait for a macrotask after each live chunk', async () => { | ||
| vi.spyOn(performance, 'now').mockReturnValue(0) | ||
| const client = new ChatClient({ | ||
| connection: createMockConnectionAdapter({ | ||
| chunks: createTextChunks('ab'), | ||
| }), | ||
| }) | ||
| let macrotaskRan = false | ||
| setTimeout(() => { | ||
| macrotaskRan = true | ||
| }, 0) | ||
|
|
||
| await client.sendMessage('Hi') | ||
|
|
||
| expect(macrotaskRan).toBe(false) | ||
| }) | ||
|
|
||
| it('falls back to a timer after a full processing slice', async () => { | ||
| vi.stubGlobal('scheduler', {}) | ||
| let time = 0 | ||
| vi.spyOn(performance, 'now').mockImplementation(() => (time += 9)) | ||
| const client = new ChatClient({ | ||
| connection: createMockConnectionAdapter({ | ||
| chunks: createTextChunks('ab'), | ||
| }), | ||
| }) | ||
| let macrotaskRan = false | ||
| setTimeout(() => { | ||
| macrotaskRan = true | ||
| }, 0) | ||
|
|
||
| await client.sendMessage('Hi') | ||
|
|
||
| expect(macrotaskRan).toBe(true) | ||
| }) | ||
|
|
||
| it('uses the scheduler after a full processing slice', async () => { | ||
| const schedulerYield = vi.fn(() => Promise.resolve()) | ||
| vi.stubGlobal('scheduler', { yield: schedulerYield }) | ||
| let time = 0 | ||
| vi.spyOn(performance, 'now').mockImplementation(() => (time += 9)) | ||
| const client = new ChatClient({ | ||
| connection: createMockConnectionAdapter({ | ||
| chunks: createTextChunks('ab'), | ||
| }), | ||
| }) | ||
| let macrotaskRan = false | ||
| setTimeout(() => { | ||
| macrotaskRan = true | ||
| }, 0) | ||
|
|
||
| await client.sendMessage('Hi') | ||
|
|
||
| expect(schedulerYield).toHaveBeenCalled() | ||
| expect(macrotaskRan).toBe(false) | ||
| }) | ||
|
|
||
| it('does not yield in a hidden document', async () => { | ||
| vi.stubGlobal('document', { hidden: true }) | ||
| const schedulerYield = vi.fn(() => Promise.resolve()) | ||
| vi.stubGlobal('scheduler', { yield: schedulerYield }) | ||
| let time = 0 | ||
| vi.spyOn(performance, 'now').mockImplementation(() => (time += 9)) | ||
| const client = new ChatClient({ | ||
| connection: createMockConnectionAdapter({ | ||
| chunks: createTextChunks('ab'), | ||
| }), | ||
| }) | ||
| let macrotaskRan = false | ||
| setTimeout(() => { | ||
| macrotaskRan = true | ||
| }, 0) | ||
|
|
||
| await client.sendMessage('Hi') | ||
|
|
||
| expect(macrotaskRan).toBe(false) | ||
| expect(schedulerYield).not.toHaveBeenCalled() | ||
| }) | ||
|
|
||
| it('shares the processing budget across live and joined streams', async () => { | ||
| let releaseYield!: () => void | ||
| const schedulerYield = vi.fn( | ||
| () => | ||
| new Promise<void>((resolve) => { | ||
| releaseYield = resolve | ||
| }), | ||
| ) | ||
| vi.stubGlobal('scheduler', { yield: schedulerYield }) | ||
| let time = 0 | ||
| vi.spyOn(performance, 'now').mockImplementation(() => (time += 5)) | ||
| const processed = vi.fn() | ||
| const chunk = (name: string): StreamChunk => ({ | ||
| type: 'CUSTOM', | ||
| name, | ||
| timestamp: Date.now(), | ||
| value: null, | ||
| }) | ||
| const client = new ChatClient({ | ||
| threadId: 't1', | ||
| connection: { | ||
| subscribe: async function* () { | ||
| yield chunk('live-1') | ||
| yield chunk('live-2') | ||
| }, | ||
| send: () => Promise.resolve(), | ||
| joinRun: async function* () { | ||
| yield chunk('joined') | ||
| }, | ||
| }, | ||
| initialResumeSnapshot: { | ||
| resumeState: { threadId: 't1', runId: 'r1' }, | ||
| }, | ||
| onChunk: processed, | ||
| }) | ||
|
|
||
| client.subscribe() | ||
| client.attach() | ||
| try { | ||
| await vi.waitFor(() => expect(schedulerYield).toHaveBeenCalledTimes(1)) | ||
| expect(processed).toHaveBeenCalledTimes(2) | ||
|
|
||
| releaseYield() | ||
| await vi.waitFor(() => expect(processed).toHaveBeenCalledTimes(3)) | ||
| expect(schedulerYield).toHaveBeenCalledTimes(1) | ||
| } finally { | ||
| client.dispose() | ||
| } | ||
| }) | ||
| }) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.