Implementation Plan: P3 Fleet Crash-Recovery and Resume Test Coverage#1563
Merged
Trecek merged 5 commits intointegrationfrom Apr 30, 2026
Merged
Conversation
… (P3) Add 15 test methods across 3 files covering WP1-WP9: - test_state.py: TOCTOU sidecar OSError→INTERRUPTED, _write_pid exception swallow, illegal state transitions, REFUSED/RELEASED resume skip, corrupt state no-op, mixed success/failure captures - test_fleet_semaphore.py: constructor guard (max_concurrent≤0), CancelledError propagates and releases semaphore lock - test_sidecar.py: read_sidecar_from_path with missing dir and valid JSONL Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Trecek
commented
Apr 30, 2026
Collaborator
Author
Trecek
left a comment
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: changes_requested
Trecek
commented
Apr 30, 2026
Collaborator
Author
Trecek
left a comment
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit review: blocking issues found. See inline comments — changes are required before merging.
1 critical finding (NameError: bogus undefined in TestWritePidExceptionSwallow.test_nonexistent_state_logs_warning), 1 warning (cohesion: test placement), 1 warning (arch: private import in test).
Adds _write_pid to fleet/__init__.py so tests can import from the public package path (autoskillit.fleet) instead of the private sub-module (autoskillit.fleet._api). Consolidates the import in test_state.py.
…i.py TestWritePidExceptionSwallow tests _write_pid from fleet/_api.py. Moving it from test_state.py to a dedicated test_api.py keeps coverage for _api.py co-located with its source module.
Trecek
commented
Apr 30, 2026
Trecek
commented
Apr 30, 2026
Trecek
commented
Apr 30, 2026
Trecek
commented
Apr 30, 2026
Trecek
commented
Apr 30, 2026
Collaborator
Author
Trecek
left a comment
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit review: warning-only findings detected. See inline comments — no blocking changes required.
Verdict: approved_with_comments
4 findings posted as inline comments (all warnings, no blocking criticals):
src/autoskillit/fleet/__init__.py— private symbol_write_pidin__all__src/autoskillit/fleet/_api.py— latent circular import via package gatewaytests/fleet/test_fleet_semaphore.py—TestExecuteDispatchCancelledErrorLockReleasecohesion placement (requires human decision)tests/fleet/test_fleet_semaphore.py— CancelledError lock release assertion incompleteness
1 info finding (no inline comment): tests/fleet/test_sidecar.py — missing malformed JSONL edge case in TestReadSidecarFromPath.
…t_api.py with strengthened lock assertion Moved TestExecuteDispatchCancelledErrorLockRelease from test_fleet_semaphore.py to test_api.py for cohesion (it tests execute_dispatch, not FleetSemaphore). Added side-effect counter inside _raise_cancelled to prove the semaphore was actually held when cancellation fired, distinguishing lock-acquired-then-released from lock-never-acquired. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Trecek
deleted the
p3-fleet-crash-recovery-and-resume-test-coverage/1541
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add ~15 test methods across 3 existing test files (
test_state.py,test_fleet_semaphore.py,test_sidecar.py) covering fleet crash-recovery paths, lock correctness, state transition guards, resume algorithm edge cases, and sidecar I/O. Pure test additions — no source files modified.Closes #1541
Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-20260430-081120-253210/.autoskillit/temp/make-plan/p3_fleet_crash_recovery_resume_test_coverage_plan_2026-04-30_081500.md🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary