P4 — Extract _subprocess.py from helpers.py and Migrate Consumers#1553
Merged
Trecek merged 6 commits intointegrationfrom Apr 30, 2026
Merged
Conversation
Trecek
commented
Apr 30, 2026
Collaborator
Author
Trecek
left a comment
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit PR Review — Verdict: approved_with_comments
Trecek
commented
Apr 30, 2026
Collaborator
Author
Trecek
left a comment
Trecek
left a comment
There was a problem hiding this comment.
AutoSkillit review: warning-only findings detected. See inline comments — no blocking changes required.
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Move _run_subprocess, _process_runner_result, _GH_API_SUBCOMMANDS, and _is_github_cli_call into server/_subprocess.py. Retarget all 6 tool files and 2 test files to import from the new location. Remove extracted symbols and orphaned imports from helpers.py. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Bump server file count limit from 22 to 23 and retarget the SubprocessResult TYPE_CHECKING contract from helpers.py to _subprocess.py. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Have _run_git delegate to _process_runner_result instead of inlining the identical TIMED_OUT→(-1, stdout, error_str) logic. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Allow autoskillit.server._subprocess in the REQ-IMP-005 import allowlist since git.py now imports _process_runner_result from it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Trecek
force-pushed
the
p4-extract-subprocess-py-from-helpers-py-and-migrate-consume/1542
branch
from
6c4239c to
377e15b
Compare
Trecek
deleted the
p4-extract-subprocess-py-from-helpers-py-and-migrate-consume/1542
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the subprocess execution concern (
_run_subprocess,_process_runner_result,_GH_API_SUBCOMMANDS,_is_github_cli_call) fromserver/helpers.pyinto a newserver/_subprocess.pymodule, along with a duplicate of the_get_ctxdeferred-import shim they depend on (the original stays inhelpers.pyfor its remaining callers). Migrate all 6 tool-file consumers and 2 test files to import from the new location. Delete the extracted symbols and their orphaned imports fromhelpers.py. No re-export shim.Closes #1542
Implementation Plan
Plan file:
/home/talon/projects/autoskillit-runs/impl-1542-20260429-203136-929608/.autoskillit/temp/make-plan/p4_extract_subprocess_py_plan_2026-04-29_203300.md🤖 Generated with Claude Code via AutoSkillit
Token Usage Summary