Skip to content

chore(QTDI-3566): Remove unused jira-credentials from Jenkins builds - #1287

Open
acatoire wants to merge 1 commit into
masterfrom
acatoire/QTDI-3566_remove_jira_credentials
Open

acatoire wants to merge 1 commit into
masterfrom
acatoire/QTDI-3566_remove_jira_credentials

Conversation

@acatoire

@acatoire acatoire commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Requirements

  • Any code change adding any logic MUST be tested through a unit test executed with the default build
  • Any API addition MUST be done with a documentation update if relevant

Why this PR is needed?

Jira: QTDI-3566

The jira-credentials Jenkins credential is still bound in the CI and release pipelines but is no longer used: the Jira changelog generation (Generator.generatedJira()) stopped being registered in #991 (QTDI-1189, Feb 2025). Since then the credential only flows into a dead Maven jira server and two unused Generator arguments. It can still break the pipeline when it is missing on the Jenkins instance (see QTDI-3536).

What does this PR adds (design/code thoughts)?

CI

  • Jenkinsfile: drop the jiraCredentials definition and its usage in the "Post login" stage and the legacy RELEASE stage.
  • ci/Jenkinsfile-release: drop the jiraCredentials definition and its usage in the "Post login", "Maven release process" and "Release studio modules" stages.
  • .jenkins/settings.xml: remove the jira Maven server (JIRA_USER/JIRA_PASS).

Documentation module (dead code)

  • documentation/pom.xml: remove the ${talend.jira.username}/${talend.jira.password} arguments from the generated-doc execution.
  • DecryptCredentials.groovy: remove decryptAndSet('jira'); fix the warning message ("contributors" instead of "changelog").
  • Generator.java: remove generatedJira(), its helpers and Jira DTOs, unused imports; shift main argument indices accordingly ([0] pages dir, [1] version, [2] offline, [3]/[4] GitHub user/password, [5] skip flag).
  • release-process.adoc: remove the Jira server/variables and the "Cleaning up JIRA" section.

Validation (local)

  • mvn -pl documentation compiler:compile exec:java@generated-doc -Dtalend.github.username=skip → BUILD SUCCESS, all doc generation tasks run, GitHub args correctly mapped (No Github credentials, will skip contributors generation).
  • DecryptCredentials.groovy runs fine with only the github server.
  • mvn -pl documentation spotless:check → clean.
  • Brace/parenthesis balance check (jenkinsfile-check.yml) OK on both Jenkinsfile and ci/Jenkinsfile-release.

Out of scope / follow-up

  • Legacy, unused files still mention TLND_JIRA_*: .travis/settings.xml, .github/workflows/maven.yml_disable.
  • Static generated_changelog.adoc is still included by changelog.adoc (left untouched).
  • Once a release has run with this change, the jira-credentials entry can be removed from the Jenkins configuration (application-flux-config, aws_rnd_ci/releases/jenkins-connectors/jenkins.yaml).

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

  • this PR has been written with the help of GitHub Copilot or another generative AI tool

The Jira changelog generation was dropped in #991 (QTDI-1189), so the
jira-credentials binding, the jira Maven server and the Generator
Jira arguments were dead code. A missing credential still broke builds
(QTDI-3536).

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@sonar-rnd

sonar-rnd Bot commented Oct 8, 2026

Copy link
Copy Markdown

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant