Repository navigation
Conversation
The Jira changelog generation was dropped in #991 (QTDI-1189), so the jira-credentials binding, the jira Maven server and the Generator Jira arguments were dead code. A missing credential still broke builds (QTDI-3536). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (63.10% Estimated after merge)
Requirements
Why this PR is needed?
Jira: QTDI-3566
The
jira-credentialsJenkins credential is still bound in the CI and release pipelines but is no longer used: the Jira changelog generation (Generator.generatedJira()) stopped being registered in #991 (QTDI-1189, Feb 2025). Since then the credential only flows into a dead Mavenjiraserver and two unused Generator arguments. It can still break the pipeline when it is missing on the Jenkins instance (see QTDI-3536).What does this PR adds (design/code thoughts)?
CI
Jenkinsfile: drop thejiraCredentialsdefinition and its usage in the "Post login" stage and the legacy RELEASE stage.ci/Jenkinsfile-release: drop thejiraCredentialsdefinition and its usage in the "Post login", "Maven release process" and "Release studio modules" stages..jenkins/settings.xml: remove thejiraMaven server (JIRA_USER/JIRA_PASS).Documentation module (dead code)
documentation/pom.xml: remove the${talend.jira.username}/${talend.jira.password}arguments from thegenerated-docexecution.DecryptCredentials.groovy: removedecryptAndSet('jira'); fix the warning message ("contributors" instead of "changelog").Generator.java: removegeneratedJira(), its helpers and Jira DTOs, unused imports; shiftmainargument indices accordingly ([0]pages dir,[1]version,[2]offline,[3]/[4]GitHub user/password,[5]skip flag).release-process.adoc: remove the Jira server/variables and the "Cleaning up JIRA" section.Validation (local)
mvn -pl documentation compiler:compile exec:java@generated-doc -Dtalend.github.username=skip→ BUILD SUCCESS, all doc generation tasks run, GitHub args correctly mapped (No Github credentials, will skip contributors generation).DecryptCredentials.groovyruns fine with only thegithubserver.mvn -pl documentation spotless:check→ clean.jenkinsfile-check.yml) OK on bothJenkinsfileandci/Jenkinsfile-release.Out of scope / follow-up
TLND_JIRA_*:.travis/settings.xml,.github/workflows/maven.yml_disable.generated_changelog.adocis still included bychangelog.adoc(left untouched).jira-credentialsentry can be removed from the Jenkins configuration (application-flux-config,aws_rnd_ci/releases/jenkins-connectors/jenkins.yaml).AI generated code
https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code