Repository navigation
fix(nix): fix build with structuredAttrs enabled - #1550
Merged
Merged
Conversation
CyanVoxel
added
Type: Installation
Member
|
Checks out for me, thank you for catching this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NixOS/nixpkgs#543976 enabled
__structuredAttrsby default forbuildPythonApplication. This breaks the build, see NixOS/nixpkgs#575801 for an explanation why it breaks and as a reference for the changes I have done.I didn't want to touch the version pin in
flake.lockand instead enabled__structuredAttrsexplicitly to retain compatibility with the old version.I also compared the output before and after with diffoscope and nothing but the store path itself and the dozens of references to it changed.
Tasks Completed