Repository navigation
feat(ui): improved inspector resizing with grid snapping and corner resize handle - #1549
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR is targeting the
devbranch for release with Alpha v9.7.Summary
(Builds off of #1548) This PR aims to improve Inspector preview resizing by snapping it to the thumbnail grid when resizing splitters (not the window), automatically resizing the height of previews with different aspect ratios while keeping them top-aligned, and by adding a new corner resize handle to the preview area to easily resize the preview diagonally across both splitters in one go.
This behavior is meant to be an "it just works" approach where you get the maximum preview size in the space available quickly and easily. Resizing a preview vertically when it no longer increases the preview size is no longer allowed, instead locking to the maximum height given the aspect ratio of the preview item. Previous tall preview drags are remembered when browsing items with different sizes, so the next time you come across a tall preview it'll expand back to the point you had previously had the splitter dragged to, at most.
This change is also made forward-compatible with the eventual feature to allow the inspector to be docked on either side of the window. Other splitter styles were not changed in this PR as I'll touch those in a more design-focused PR shortly.
Tasks Completed