fix: sidebar gap when switching between table and query tabs (#759)#761
Closed
fix: sidebar gap when switching between table and query tabs (#759)#761
Conversation
The "Toggle Results" ToolbarItem was conditionally added/removed based on isTableTab. NavigationSplitView's NSSplitViewController recalculates the sidebar's top safe-area inset when toolbar items change on the detail column, producing a visible gap shift. Fix: always include the ToolbarItem but hide it on table tabs with opacity(0) + allowsHitTesting(false). This keeps the toolbar layout stable across tab switches, preventing the sidebar inset recalculation. Closes #759
datlechin
force-pushed
the
fix/sidebar-gap-stable-toolbar-759
branch
from
912f843 to
000222d
Compare
Collaborator
Author
|
Closing — the opacity/allowsHitTesting approach causes an NSView layout loop crash when closing tabs. The sidebar gap (#759) needs a different fix approach (likely fixing the sidebar's safeAreaInset to not depend on toolbar item count). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The "Toggle Results" toolbar button was conditionally added/removed based on tab type.
NavigationSplitView'sNSSplitViewControllerrecalculates the sidebar's top safe-area inset whenever toolbar items change on the detail column, producing a visible gap shift.Always include the button but hide it on table tabs with
opacity(0)+allowsHitTesting(false). Toolbar layout stays stable across tab switches.1 file, 16 additions, 12 deletions.
Test plan
Closes #759