fix: apply PathPortability to iCloud sync#756
Merged
Conversation
) Device-local filesystem paths (SSH key, agent socket, SSL certs) were synced as raw absolute paths, breaking connections on other devices. Apply the same PathPortability pattern already used in connection export: contract paths to ~/… form before pushing to iCloud, expand them back to device-local form when pulling. This makes paths work across Macs with different usernames and prevents iOS from overwriting valid paths. Covers: SSHConfiguration (privateKeyPath, agentSocketPath), SSHJumpHost (privateKeyPath), SSHProfile (privateKeyPath, agentSocketPath, jumpHosts), SSLConfiguration (caCertificatePath, clientCertificatePath, clientKeyPath). Closes #750
datlechin
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Device-local filesystem paths (SSH key, agent socket, SSL certs) were synced as raw absolute paths (e.g.,
/Users/alice/.ssh/id_rsa), breaking connections on other devices. Applied the samePathPortabilitypattern already used in connection export: contract paths to~/…form before pushing to iCloud, expand to device-local form when pulling.All 9 path fields covered:
privateKeyPath,agentSocketPathprivateKeyPathprivateKeyPath,agentSocketPath, jump host pathscaCertificatePath,clientCertificatePath,clientKeyPathOne file changed:
SyncRecordMapper.swift— 6 helper methods + 4 call sites.Test plan
~/.ssh/id_ed25519→ sync → Mac B has correct path for its own home dirCloses #750