Repository navigation
test(linux): retry a fixture's start when its image pull fails - #3828
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tablepro_test_fixtures::start_containertakes a closure that builds the container request. When testcontainers reports that pulling the image failed, it builds and starts the request again, up to three times 5 seconds apart.mainat c6eb271.docs/testing.md, Docker or Podman, says so.Test plan
a_pull_that_keeps_failing_is_tried_three_times_and_reported(requires docker): an image tag that does not exist fails with the pull error after three attempts.-D warnings,cargo fmt --check.