Skip to content

fix(ios): adopt iOS 26 close, cancel, and confirm button roles in sheets#1525

Merged
datlechin merged 2 commits into
TableProApp:mainfrom
zunda-pixel:fix/ios-1524-close-confirm-button-roles
May 31, 2026
Merged

fix(ios): adopt iOS 26 close, cancel, and confirm button roles in sheets#1525
datlechin merged 2 commits into
TableProApp:mainfrom
zunda-pixel:fix/ios-1524-close-confirm-button-roles

Conversation

@zunda-pixel
Copy link
Copy Markdown
Contributor

@zunda-pixel zunda-pixel commented May 31, 2026

Closes #1524

iOS sheet dismiss and confirm buttons were custom flat buttons, inconsistent with the native iOS 26 controls used by system apps like Mail. iOS 26 adds semantic button roles that let the system render the Liquid Glass control (shape, material, spacing, typography) automatically.

Changes

  • Add SemanticButtons.swift with CloseButton, CancelButton, and ConfirmButton. Each uses the iOS 26 role (.close / .cancel / .confirm) when available and falls back to a titled button on iOS 18.
  • Adopt them across the sheets: connection form, insert row, filters, tag/group forms, tag/group management, FK preview, row detail, and the Settings sheet.
  • Use CancelButton for the Cancel actions in alerts and confirmation dialogs, and for the inline Cancel on the connecting screen.

Notes

  • Deployment target stays at iOS 18. The new roles are gated with if #available(iOS 26.0, *).
  • On iOS 26 the role buttons use the system-provided presentation, so the explicit titles ("Done", "Cancel") only render on the iOS 18 fallback path.
Before After
image image

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 31, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

github-actions Bot added a commit that referenced this pull request May 31, 2026
@zunda-pixel zunda-pixel changed the title Add SemanticButtons fix(ios): adopt iOS 26 close, cancel, and confirm button roles in sheets May 31, 2026
@zunda-pixel zunda-pixel marked this pull request as ready for review May 31, 2026 14:07
Copy link
Copy Markdown
Member

@datlechin datlechin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@datlechin datlechin merged commit d42f564 into TableProApp:main May 31, 2026
2 of 3 checks passed
@zunda-pixel zunda-pixel deleted the fix/ios-1524-close-confirm-button-roles branch May 31, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iOS 26 Close/Cancel Button UI

2 participants