Skip to content

Add BitNuker Fantasy Environments Sampler (2D) - #130

Merged
TMHSDigital merged 7 commits into
TMHSDigital:mainfrom
mattzornow:add-bitnuker-fantasy-environments-sampler
Oct 23, 2026
Merged

TMHSDigital merged 7 commits into
TMHSDigital:mainfrom
mattzornow:add-bitnuker-fantasy-environments-sampler

Conversation

@mattzornow

Copy link
Copy Markdown
Contributor

Self-submission disclosure: I am the publisher (BitNuker) submitting my own free sampler, following the same pattern as PR #129 (BitNuker Workshop Sampler, merged earlier today). Per CONTRIBUTING's 'Submitting your own source', the entry starts at needs-review so a maintainer re-reads the license before it goes active. All license facts were read at the live source page (https://bitnuker.itch.io/fantasy-environments-sampler) on 2026-10-23, the day of submission. There is deliberately no license_spdx line: the license is 'custom' with no SPDX mapping. Changes: the new catalog entry, its row in catalog/2d/README.md, and +1 count updates (total and 2D) in README.md, catalog/README.md, and site/config.json expectedEntryCount. Edits were made in the web editor, so no local test run; the diff has been checked line by line for unintended changes.

@TMHSDigital TMHSDigital left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-read the licence at https://bitnuker.itch.io/fantasy-environments-sampler on 2026-10-23. The three Evidence quotes match the page's "License" section word for word, the AI disclosure is there as quoted, and the listing is a free download (the paid Grounds, Skies & Horizons and Complete packs are named in Notes only, not linked as the entry's url). Thanks for following the own-source pattern from #129: third-party wording, needs-review start, custom without license_spdx, publisher set, ai-generated tag.

Checked out the branch and ran the repo checks: checks.test 150/150, lib.test 553/553, validate ok: 417 entries, sync-counts --check agrees (417 total, 2D 60). The README table, the badge, catalog/README.md, the 2D README row and expectedEntryCount all line up.

One note, no change needed: the branch predates the site refresh that landed on main today (#131), so the new site will show this entry with a typographic tile rather than a preview image, as it does for every custom-licence entry. That is by design.

Approving. Since the licence has now been read at the source by a maintainer, the status can go to active after merge.

@TMHSDigital
TMHSDigital merged commit ec218e3 into TMHSDigital:main Oct 23, 2026
3 checks passed
TMHSDigital pushed a commit that referenced this pull request Oct 30, 2026
* Fantasy Environments Sampler: status to active

* Fantasy Environments Sampler: README status to active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants