Repository navigation
fix(ci): close five gates that checked less than they claimed - #419
Merged
Merged
Conversation
- release-gate.sh (#365): the compare/commit APIs return at most 300 files in path order, so a large docs/gallery regeneration could hide a later code change and the gate released on Validate alone. A list of 300+ files now counts as "smoke applies". SMOKE_TIMEOUT defaults to 5400 s (the job's 75 minutes plus queueing) instead of 3600. - drift-check.yml / release.yml (#363): both composite actions check out and run the meta-repo's Python at meta-repo-ref, which was the floating v1 tag and the v1.15.1 tag. Both are now commit SHAs, and the Validate pin check rejects a tag meta-repo-ref. - check_site_links.py (#366): a relative link that climbs out of the site resolved to a repo file in CI and passed; it now fails. src on iframe, video, audio, source and embed is checked too. - check_skill_refs.py (#395): bare-path detection covered four directories, so `docs/technical-audit.md` in vse-python shipped as a dead path to plugin users. It now covers every top-level directory and relative markdown links; the vse-python reference is linked. - asset_sheet.py (#367): butter-churn had no SELECT row, so its committed asset sheet could not be regenerated. Row added, and tests/check_asset_sheet_select.py (run by Validate) requires a row for every showcase piece and every CLAUDE.md reference. Closes #363 Closes #365 Closes #366 Closes #367 Closes #395 Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
Author
|
CI evidence before merge: all checks pass ( 13 pass ). Blender Smoke on PR head: Blender 5.2.2 LTS / Blender 4.5.14 LTS. Summaries (happy path; falsifiers) per leg: 143 passed, 1 skipped, 0 failed;142 passed, 0 skipped, 0 failed;141 passed, 3 skipped, 0 failed;136 passed, 6 skipped, 0 failed; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #363, #365, #366, #367, #395.
release-gate.shdocs/galleryregeneration could hide a code change that sorts after it, and the release went out on Validate alone. Separately,SMOKE_TIMEOUT3600 s was below the job's 75 minSMOKE_TIMEOUTdefaults to 5400 s (75 min + 15 min queue)meta-repo-ref: the floatingv1tag, andv1.15.1in thecontents: writejob7886cbe6(=v1=v1.19.2today, so no behaviour change) and9be79799(=v1.15.1). The Validate pin step rejects a tagmeta-repo-refcheck_site_links.pysrcwas never checkedcheck_skill_refs.pydocs/technical-audit.mdpath shipped invse-pythonvse-pythonline is linkedasset_sheet.pybutter-churnSELECT row, so its committed sheet couldn't be regenerated^ChurnLow$). Newtests/check_asset_sheet_select.pyin Validate requires a row for every showcase piece and every CLAUDE.md asset referenceEvidence (local; no Blender needed). Each new check was falsified once.
tests/test_release_gate.py12/12 OK, including the newtest_truncated_file_list_waits_for_smokeandtest_299_docs_files_still_skip_smoke. With the 300-file line deleted, the truncation test fails. Restored, it passes.release.yml:145: meta-repo-ref: v1.15.1onmainand nothing on this branch. SHAs were resolved viagh api …/git/tags/2bb837a2…(→ commit 9be79799) and…/commits/v1(→ 7886cbe6). All three workflow files parse as YAML._sitewith<a href="../secret.txt">(the file exists one level up),<iframe src="nope.html">and a valid<video src="ok.mp4">now gives2 failures, exit 1: escaping link plus missing iframe; the video passes;135 pages, 7137 internal references, 0 failures.::error::skills/vse-python/SKILL.md:150: bare repo path docs/technical-audit.md(exit 1). After, it passes. Regex spot checks:](../../snippets/a.py)and](docs/x.md)are flagged; absolute links are not.asset_sheet.pyreverted, the new check printsshowcase piece 'butter-churn' has no SELECT row, exit 1. Restored, it passes.build_churn_mesh("ChurnLow", …)object name, the same<Name>Lowconvention as the other 75 rows.🤖 Generated with Claude Code