Skip to content

fix(ci): close five gates that checked less than they claimed - #419

Merged
TMHSDigital merged 1 commit into
mainfrom
fix/tooling-gates-batch
Oct 5, 2026
Merged

TMHSDigital merged 1 commit into
mainfrom
fix/tooling-gates-batch

Conversation

@TMHSDigital

Copy link
Copy Markdown
Owner

Closes #363, #365, #366, #367, #395.

Issue Gate Hole Fix
#365 release-gate.sh The compare/commit APIs cap at 300 files in path order, so a big docs/gallery regeneration could hide a code change that sorts after it, and the release went out on Validate alone. Separately, SMOKE_TIMEOUT 3600 s was below the job's 75 min 300+ files count as "smoke applies". SMOKE_TIMEOUT defaults to 5400 s (75 min + 15 min queue)
#363 drift-check / release-doc-sync Both composite actions run the meta-repo's Python at meta-repo-ref: the floating v1 tag, and v1.15.1 in the contents: write job Both pass full SHAs: 7886cbe6 (= v1 = v1.19.2 today, so no behaviour change) and 9be79799 (= v1.15.1). The Validate pin step rejects a tag meta-repo-ref
#366 check_site_links.py A relative link escaping the site resolved to a repo file in CI and passed; iframe/video/audio/source/embed src was never checked Escaping links fail; those tags are checked
#395 check_skill_refs.py Bare-path detection covered 4 directories, so a dead docs/technical-audit.md path shipped in vse-python Every top-level directory plus relative markdown links; the vse-python line is linked
#367 asset_sheet.py No butter-churn SELECT row, so its committed sheet couldn't be regenerated Row added (^ChurnLow$). New tests/check_asset_sheet_select.py in Validate requires a row for every showcase piece and every CLAUDE.md asset reference

Evidence (local; no Blender needed). Each new check was falsified once.

🤖 Generated with Claude Code

- release-gate.sh (#365): the compare/commit APIs return at most 300
  files in path order, so a large docs/gallery regeneration could hide a
  later code change and the gate released on Validate alone. A list of
  300+ files now counts as "smoke applies". SMOKE_TIMEOUT defaults to
  5400 s (the job's 75 minutes plus queueing) instead of 3600.
- drift-check.yml / release.yml (#363): both composite actions check
  out and run the meta-repo's Python at meta-repo-ref, which was the
  floating v1 tag and the v1.15.1 tag. Both are now commit SHAs, and the
  Validate pin check rejects a tag meta-repo-ref.
- check_site_links.py (#366): a relative link that climbs out of the
  site resolved to a repo file in CI and passed; it now fails. src on
  iframe, video, audio, source and embed is checked too.
- check_skill_refs.py (#395): bare-path detection covered four
  directories, so `docs/technical-audit.md` in vse-python shipped as a
  dead path to plugin users. It now covers every top-level directory and
  relative markdown links; the vse-python reference is linked.
- asset_sheet.py (#367): butter-churn had no SELECT row, so its
  committed asset sheet could not be regenerated. Row added, and
  tests/check_asset_sheet_select.py (run by Validate) requires a row for
  every showcase piece and every CLAUDE.md reference.

Closes #363
Closes #365
Closes #366
Closes #367
Closes #395

Signed-off-by: TMHSDigital <154358121+TMHSDigital@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@TMHSDigital

Copy link
Copy Markdown
Owner Author

CI evidence before merge: all checks pass ( 13 pass ). Blender Smoke on PR head: Blender 5.2.2 LTS / Blender 4.5.14 LTS. Summaries (happy path; falsifiers) per leg: 143 passed, 1 skipped, 0 failed;142 passed, 0 skipped, 0 failed;141 passed, 3 skipped, 0 failed;136 passed, 6 skipped, 0 failed;

@TMHSDigital
TMHSDigital merged commit 536f60f into main Oct 5, 2026
13 checks passed
@TMHSDigital
TMHSDigital deleted the fix/tooling-gates-batch branch October 5, 2026 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: pinned composite actions still execute code from mutable tags (meta-repo-ref v1.15.1 / v1) (#306 incomplete)

1 participant