Skip to content

UX: Always show cancel and continue button in start/join room dialog #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
samuelwei wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

UX: Always show cancel and continue button in start/join room dialog #2333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95ffda4
UX: Always show cancel and continue button in start/join room dialog
samuelwei Jul 24, 2025
b8e6a26
Update changelog
samuelwei Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- Cancel and Continue buttons not immediately visible on small screens in the Start/Join Room dialog ([#2333])

## [v4.7.0] - 2025-07-21

### Added
Expand Down Expand Up @@ -522,6 +526,7 @@ You can find the changelog for older versions there [here](https://github.com/TH
[#2265]: https://github.com/THM-Health/PILOS/issues/2265
[#2279]: https://github.com/THM-Health/PILOS/pull/2279
[#2282]: https://github.com/THM-Health/PILOS/pull/2282
[#2333]: https://github.com/THM-Health/PILOS/pull/2333
[unreleased]: https://github.com/THM-Health/PILOS/compare/v4.7.0...develop
[v3.0.0]: https://github.com/THM-Health/PILOS/releases/tag/v3.0.0
[v3.0.1]: https://github.com/THM-Health/PILOS/releases/tag/v3.0.1
Expand Down
10 changes: 6 additions & 4 deletions resources/js/components/RoomJoinButton.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
<Message v-if="showRunningMessage" class="mb-4" severity="warn">{{
$t("app.errors.room_already_running")
}}</Message>
<form ref="joinForm" @submit.prevent="getJoinUrl">
<form ref="joinForm" id="startJoinForm" @submit.prevent="getJoinUrl">
<OverlayComponent :show="isLoadingAction || loadingError" :opacity="0">
<template #overlay>
<LoadingRetryButton
Expand Down Expand Up @@ -152,8 +152,9 @@
</div>
</div>
</OverlayComponent>

<div class="flex justify-end gap-2">
</form>
<template #footer>
<div class="mt-3 flex shrink-0 justify-end gap-2">
<Button
:label="$t('app.cancel')"
data-test="dialog-cancel-button"
Expand All @@ -168,9 +169,10 @@
:disabled="isLoadingAction || loadingError"
size="small"
type="submit"
form="startJoinForm"
/>
</div>
</form>
</template>
</Dialog>
</template>
<script setup>
Expand Down
Loading