Repository navigation
Let staff switch control victory off for one field battle - #241
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
github-actions
Bot
added
the
size:M
A field battle's edit menu has a Control victory button (slot 16). Turned off before the battle starts, that battle cannot be won by control: no control builds up, the sidebar shows none, and the time cap falls back to lives. It ends on lives or retreat, as before control victory existed. The setting is saved with the battle; older saves and new battles keep control on, and changing the template resets it with the other rules. battle.control.enabled still turns control off for every battle, and the button says so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drefvelin
force-pushed
the
feat/battle-control-toggle
branch
from
November 11, 2026 11:44
aeea6fd to
079febb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Player feedback on 4.27.0 asked for lives-only field battles as an option.
/battle editmenu (slot 16), staff only like the rest of the editor. It can be changed before the battle starts and is locked after.FieldControlService.isActiveis false for that battle, so there's no control accrual, no control sidebar lines, and the time cap falls back to lives. The battle ends on lives or retreat.controlVictoryOffin the battle data. Older saves and new battles have control on. A template change resets it with the other base rules.battle.control.enabled: falsestill turns control off globally; the button's lore says so when that's the case.Tests: mapper round-trip and legacy default,
isActiveand sidebar with the toggle off, the editor button's lore (on, off, globally off, locked), and click handling for field and non-field battles. Full local suite: only the known local-onlyQuarantineCommandsTestfailure and the baseline coverage misses.🤖 Generated with Claude Code