Skip to content

fix: remove shell=True to prevent shell injection vulnerabilities #2139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jah-yee wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: remove shell=True to prevent shell injection vulnerabilities #2139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9ee76f2
Fix: Replace shell=True to prevent shell injection
Apr 4, 2026
a14a772
Fix shell injection security vulnerability (shell=True -> shell=False)
Apr 7, 2026
f936560
fix(security): replace shell=True with shell=False to prevent shell i…
Apr 7, 2026
61c2ceb
fix: replace shell=True to prevent shell injection vulnerabilities
Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ples/voice-assistant-nodejs/tenapp/ten_packages/extension/main_nodejs/tools/run_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# See the LICENSE file for more information.
#
import argparse
import shlex
import subprocess
import sys
import os
Expand All @@ -15,7 +16,8 @@ def run_cmd(cmd: str, env: dict[str, str] | None = None) -> int:
if env is None:
env = os.environ.copy()
print(f"Running: {cmd}")
result = subprocess.run(cmd, shell=True, check=True, env=env)
# Use shell=False to avoid shell injection vulnerabilities
result = subprocess.run(shlex.split(cmd), shell=False, check=True, env=env)
return result.returncode


Expand Down
4 changes: 3 additions & 1 deletion packages/core_apps/default_app_cpp/tools/run_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

import argparse
import platform
import shlex
import subprocess
import sys

Expand Down Expand Up @@ -52,7 +53,8 @@ def detect_arch() -> str:
def run_cmd(cmd: str) -> int:
"""Run a shell command."""
print(f"Running: {cmd}")
result = subprocess.run(cmd, shell=True, check=True)
# Use shell=False to avoid shell injection vulnerabilities
result = subprocess.run(shlex.split(cmd), shell=False, check=True)
return result.returncode


Expand Down
4 changes: 3 additions & 1 deletion packages/core_extensions/default_extension_cpp/tools/run_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#
import argparse
import platform
import shlex
import subprocess
import sys
import os as os_module
Expand Down Expand Up @@ -53,7 +54,8 @@ def run_cmd(cmd: str, env: dict[str, str] | None = None) -> int:
if env is None:
env = os_module.environ.copy()
print(f"Running: {cmd}")
result = subprocess.run(cmd, shell=True, check=True, env=env)
# Use shell=False to avoid shell injection vulnerabilities
result = subprocess.run(shlex.split(cmd), shell=False, check=True, env=env)
return result.returncode


Expand Down
6 changes: 3 additions & 3 deletions packages/core_extensions/default_extension_nodejs/tests/bin/start.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@

# npm install
print("Running npm install...")
result = subprocess.run(["npm", "install"], env=env, shell=True)
result = subprocess.run(["npm", "install"], env=env)
if result.returncode != 0:
print("npm install failed")
sys.exit(result.returncode)

# npm run build
print("Running npm run build...")
result = subprocess.run(["npm", "run", "build"], env=env, shell=True)
result = subprocess.run(["npm", "run", "build"], env=env)
if result.returncode != 0:
print("npm run build failed")
sys.exit(result.returncode)
Expand Down Expand Up @@ -51,5 +51,5 @@

# npm test
print("Running npm test...")
result = subprocess.run(["npm", "test"], env=env, shell=True)
result = subprocess.run(["npm", "test"], env=env)
sys.exit(result.returncode)
4 changes: 3 additions & 1 deletion packages/core_extensions/default_extension_nodejs/tools/run_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# See the LICENSE file for more information.
#
import argparse
import shlex
import subprocess
import sys
import os
Expand All @@ -15,7 +16,8 @@ def run_cmd(cmd: str, env: dict[str, str] | None = None) -> int:
if env is None:
env = os.environ.copy()
print(f"Running: {cmd}")
result = subprocess.run(cmd, shell=True, check=True, env=env)
# Use shell=False with shlex.split to avoid shell injection vulnerabilities
result = subprocess.run(shlex.split(cmd), shell=False, check=True, env=env)
return result.returncode


Expand Down
4 changes: 3 additions & 1 deletion packages/example_apps/transcriber_demo/ten_packages/extension/vtt_nodejs/tools/run_script.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# See the LICENSE file for more information.
#
import argparse
import shlex
import subprocess
import sys
import os
Expand All @@ -15,7 +16,8 @@ def run_cmd(cmd: str, env: dict[str, str] | None = None) -> int:
if env is None:
env = os.environ.copy()
print(f"Running: {cmd}")
result = subprocess.run(cmd, shell=True, check=True, env=env)
# Use shell=False with shlex.split to avoid shell injection vulnerabilities
result = subprocess.run(shlex.split(cmd), shell=False, check=True, env=env)
return result.returncode


Expand Down
6 changes: 3 additions & 3 deletions ...e/integration/nodejs/standalone_test_nodejs_2/default_extension_nodejs/tests/bin/start.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@

# npm install
print("Running npm install...")
result = subprocess.run(["npm", "install"], env=env, shell=True)
result = subprocess.run(["npm", "install"], env=env)
if result.returncode != 0:
print("npm install failed")
sys.exit(result.returncode)

# npm run build
print("Running npm run build...")
result = subprocess.run(["npm", "run", "build"], env=env, shell=True)
result = subprocess.run(["npm", "run", "build"], env=env)
if result.returncode != 0:
print("npm run build failed")
sys.exit(result.returncode)
Expand All @@ -50,5 +50,5 @@

# npm test
print("Running npm test...")
result = subprocess.run(["npm", "test"], env=env, shell=True)
result = subprocess.run(["npm", "test"], env=env)
sys.exit(result.returncode)
4 changes: 2 additions & 2 deletions ...e/integration/nodejs/standalone_test_nodejs_3/default_extension_nodejs/tests/bin/start.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,14 +16,14 @@

# npm install
print("Running npm install...")
result = subprocess.run(["npm", "install"], env=env, shell=True)
result = subprocess.run(["npm", "install"], env=env)
if result.returncode != 0:
print("npm install failed")
sys.exit(result.returncode)

# npm run build
print("Running npm run build...")
result = subprocess.run(["npm", "run", "build"], env=env, shell=True)
result = subprocess.run(["npm", "run", "build"], env=env)
if result.returncode != 0:
print("npm run build failed")
sys.exit(result.returncode)
Expand Down
Loading