more sensible handling of our special hotkey default binding "conflicts" #4584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I had a different solution in #4516 but I wasn't necessarily fully happy with that. (Not sure either way about this PR -- haven't looked at it carefully yet.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously I'd introduced code to automatically detect conflicts with our default hotkey bindings. I had made it ignore RA hotkeys, since some of those are bound to the same keys as other hotkeys but that didn't seem to be an actual issue.
I think this way of doing it is better, though: Instead of ignoring RA hotkeys, ignore the other group that has the same keys bound: TAStudio's analog edit hotkeys. I think this is better because MainForm.Hotkey.cs has special handling for analog editing mode, which prevents all other hotkeys from being triggered if analog edit mode is active. So it is actually impossible for these to conflict with anything else. But there is no such special handling for RA hotkeys. (Maybe there should be? I don't know.)
Someone familiar with the RA integration might have a different idea here.