Repository navigation
Conversation
GPS is not required it's just a funny feature. I can set this so maybe more ppl can use it if there are restrictions because of this.
Fixing accidentally closing forms
Fixing "No save state for forms"
Test Results1 tests 1 ✅ 0s ⏱️ Results for commit 3051be3. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several bug fixes
This pull request introduces significant improvements to state management for modal sheets in the wine listing and detail screens, ensuring that sheet state is properly reset when opened for different items or sessions. It also refactors state preservation in Compose components to use
rememberSaveablewith custom keys, preventing stale or incorrect data when switching between different wines or filters. Additionally, it makes minor adjustments to Android permissions and UI behavior.State Management and Preservation Improvements:
Added session IDs (
sessionId,filterSheetSessionId,wineFormSessionId,editSheetSessionId) to sheet-related state classes (WineListState,WineDetailState) and increment these IDs when opening sheets, ensuring that sheet state is reset for each session. Components now receive these session IDs as parameters and use them as keys forrememberSaveable, so that form and filter state does not leak between sessions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]Refactored all stateful variables in
WineFormSheetandWineFilterSheetto userememberSaveablewith the new session keys, ensuring that their values are properly scoped to the current editing/filtering context. [1] [2] [3] [4]UI/UX Adjustments:
Changed
skipPartiallyExpandedfromtruetofalsein modal bottom sheets, allowing partial expansion for better user experience. [1] [2]Ensured that filter and form values are always converted to the correct types (
Setfor filters) before being applied.Other Improvements:
Updated Compose state initialization in
SummaryStepContentto userememberSaveablefor the date picker dialog, preserving its state across recompositions. [1] [2]Marked certain Android permissions as not required (
android:required="false") in the manifest, making the app more flexible for devices that lack these features.