Skip to content

Validate Remote Path field against OpenVMS directory specs #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SteveIves merged 1 commit into from
Nov 10, 2026
Merged

Validate Remote Path field against OpenVMS directory specs #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 48 additions & 2 deletions SFTPSyncUI/SettingsForm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,14 @@ public partial class SettingsForm : Form
private AppSettings? _settings = null;
private bool initialUiLoad = false;
private bool _syncRunning = false;
private bool _invalidRemotePathOnLoad = false;

private const string InvalidRemotePathMessage =
"The remote path must be specified in Linux format (for example /dga1303/1tallent/win), " +
"not as an OpenVMS directory specification. Characters [ and ] are not allowed.";

private static bool ContainsVmsBrackets(string? path) =>
path != null && path.IndexOfAny(['[', ']']) >= 0;

public SettingsForm(AppSettings settings, bool syncRunning)
{
Expand All @@ -33,6 +41,14 @@ public SettingsForm(AppSettings settings, bool syncRunning)

textBoxRemotePassword.Text = _settings.RemotePassword.Length > 0 ? DPAPIEncryption.Decrypt(_settings.RemotePassword) : String.Empty;

//A previously saved path may contain an OpenVMS directory spec. If so, blank it
//out and tell the user once the form is shown.
if (ContainsVmsBrackets(_settings.RemotePath))
{
_settings.RemotePath = String.Empty;
_invalidRemotePathOnLoad = true;
}

textBoxRemotePath.Text = _settings.RemotePath;
buttonVerifyAccess.Enabled = !_settings.AccessVerified;

Expand All @@ -50,6 +66,16 @@ public SettingsForm(AppSettings settings, bool syncRunning)

private void SettingsForm_Shown(object sender, EventArgs e)
{
if (_invalidRemotePathOnLoad)
{
MessageBox.Show(
"The saved remote path was in OpenVMS directory format and has been cleared.\n\n" + InvalidRemotePathMessage,
"Invalid Remote Path",
MessageBoxButtons.OK,
MessageBoxIcon.Error);
textBoxRemotePath.Focus();
}

if (_syncRunning)
{
MessageBox.Show("Changes will not take effect until sync is restarted!", "Sync Running", MessageBoxButtons.OK, MessageBoxIcon.Information);
Expand Down Expand Up @@ -233,8 +259,28 @@ private void textBoxRemotePassword_TextChanged(object sender, EventArgs e)
}
private void textBoxRemotePath_TextChanged(object sender, EventArgs e)
{
if (!initialUiLoad)
_settings?.RemotePath = textBoxRemotePath.Text;
if (initialUiLoad)
return;

//The remote path must be a Linux-style path. An OpenVMS directory spec
//(e.g. $1$DGA1303:[1tallent.WIN]) contains square brackets, and will cause
//problems if it is allowed to be used.
if (ContainsVmsBrackets(textBoxRemotePath.Text))
{
//Clearing the field re-enters this handler, which stores the empty value.
textBoxRemotePath.Clear();

MessageBox.Show(
InvalidRemotePathMessage,
"Invalid Remote Path",
MessageBoxButtons.OK,
MessageBoxIcon.Error);

textBoxRemotePath.Focus();
return;
}

_settings?.RemotePath = textBoxRemotePath.Text;
}

// ----- APPLICATION SETTINGS CODE -----
Expand Down
Loading