feat(ci): automate release process - #292
Merged
Merged
Conversation
sabinem
changed the title
marftn
suggested changes
Sep 7, 2026
marftn
left a comment
marftn
left a comment
There was a problem hiding this comment.
Overall this is good but there are a few issues with the way versions are managed. Also the PR contains quite a lot of AI comments, and I think some of them could be simplified or just removed.
sabinem
force-pushed
the
feat/automate-release-process
branch
from
September 8, 2026 05:40
cbd3a3b to
a48b736
Compare
CI built and pushed the container images but never the chart, so deploying meant copying the chart out of a checkout by hand. It now publishes the chart to GHCR too, and a deployment can install a pinned version. The chart carries its own version, separate from the app's: a chart fix needs no app release, and an app release does not republish a chart that has not changed. Two things were broken underneath and are fixed here. The repo's version numbers had drifted apart (VERSION, both components and package.json each said something different), and `just version::bump` crashed instead of fixing them. CI also gained three checks: the versions agree, the chart lints, and the chart version was bumped whenever the chart changed. style: reformat ci-cd.md treefmt output only — realigns a markdown table column and rewraps two paragraphs. No wording changes.
sabinem
force-pushed
the
feat/automate-release-process
branch
from
September 8, 2026 05:52
a48b736 to
0a58895
Compare
Collaborator
Author
|
@marftn Thanks for the great review. I took care of your suggestions. The Chart and App Versions are now decoupled. Please review again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR automates the publishing of the Helm chart, so deployments can be automized.
Before: CI built and pushed the container images, but the Helm chart only ever lived in the repo. Anyone deploying Hackagon had to copy the chart out of a checkout and work out for themselves which image versions belonged with it.
Now: CI publishes the chart too. Deploying becomes one command with a version that can be set.
The chart gets its own version number, independent of the app's: so a chart fix doesn't force an app release, and an app release doesn't republish a chart that hasn't changed.
Fixed: Underneath, two things were broken and are fixed here: the repo's version numbers had all drifted apart, and the command meant to keep them in step crashed instead.
Not done yet: nothing has actually been published. That needs the first release tag pushed, and someone making the new GHCR packages public: they're private by default.
Verified: the chart lints, renders and packages locally, and the new checks catch the mistakes they're meant to. The upload itself has no local coverage: it needs a tag and org credentials.