fix: Update Glob to fix memory leak issue from inflight #430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@mkonikov thanks for the PR! Can you help to fix the failed actions? |
Author
|
@daniloab Updated the lock files. Should work now. Please rerun. |
Collaborator
|
@mkonikov would you mind check again audit and tests for 18x? Thanks for helping! |
* Fix node versions in ci matrix * Update cli.spec.js.snap * Update ci.yml
Author
|
@daniloab Fixed! (Needed to update Glob to v11 and other packages to pass audits) |
Author
|
@daniloab Look good? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the glob dependency to v10, which removes the dependency on the abandoned and vulnerable inflight package.
Glob 11 (the oldest non vulnerable version) updated the min required node version to 20, so made updates accordingly. Updated jest to recent version so tests will pass.
Workflows
Fixed the ci workflow that was trying to use a matrix for different node versions but was not actually using the intended node versions. Updated to checkout v4 at same time.
Associated Issues
Fixes #277
Fixes #429