fix: treat prompt timeout as inactivity limit - #2
Open
wylab wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PrimeSession.prompt_streamcomputes one absolute deadline for an entire agent turn. Active turns that continuously emit events are therefore aborted after 600 seconds withPrimeRequestTimeout("prompt_events", ...).Fix
Apply
prompt_timeoutto each wait for the next event. The timeout now detects an inactive/stalled stream without imposing a total runtime limit on healthy long-running turns.Regression coverage
The fake RPC emits progress events for longer than the configured timeout while keeping every inter-event gap below it. The new test fails on the old absolute-deadline behavior and passes with the inactivity timeout.
Validated with:
pytest -q(16 passed)ruff check .mypy src