SUMO-278456 | Changes to fix arn fidings with ESC AWS region. Changes…#31
Merged
SUMO-278456 | Changes to fix arn fidings with ESC AWS region. Changes…#31
Conversation
… script to print the correct ARN based on dynamically fetching partition by aws cli command
sumoanema
requested review from
akhil-sumologic,
Copilot and
npande
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
Updates deployment/cleanup scripts to print Lambda Layer ARNs with the correct AWS partition (e.g., aws, aws-cn, aws-us-gov) by deriving the partition dynamically via AWS CLI.
Changes:
scripts/zip.sh: Derives AWS partition fromsts get-caller-identityand uses it when printing the deployed Layer ARN.scripts/delete_old_layer_versions.sh: Derives AWS partition similarly and uses it when printing the deleted Layer ARN.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/zip.sh | Builds/publishes layers and now prints ARNs using a dynamically-derived partition. |
| scripts/delete_old_layer_versions.sh | Deletes layer versions and now prints ARNs using a dynamically-derived partition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…zip.sh deployment script
…ed further for other non-standard partition - keeping the default script zip.sh unchanged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… script to print the correct ARN based on dynamically fetching partition by aws cli command
PR Details
SUMO-278456 | Changes to fix arn fidings with ESC AWS region. Changes script to print the correct ARN based on dynamically fetching partition by aws cli command
Description
SUMO-278456 | Changes to fix arn fidings with ESC AWS region. Changes script to print the correct ARN based on dynamically fetching partition by aws cli command
Related Issue
https://sumologic.atlassian.net/browse/SUMO-278456
Checklist