Fix exhibit TOC page numbering - #1092
Open
nonprofittechy wants to merge 2 commits into
Open
Conversation
nonprofittechy
marked this pull request as ready for review
August 17, 2026 19:40
Member
Author
|
@rajeswari1301 this is not urgent at all (a very old correctness issue for a lightly used feature), but review if you can some day this week? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #884.
Root cause
ALExhibitList._update_page_numbers()already includes every preceding exhibit cover in each exhibit'sstart_page. The TOC template then addedloop.index, counting those covers a second time. That produced the reported increasing error:3, 6, 9instead of the physical content pages3, 5, 7.The no-cover expression also counted the default one-page TOC twice.
What changed
ALExhibit.toc_page_number()as the single, documented calculation for the first uploaded page.Before and after
Both screenshots come from the same local reproduction: three separate one-page exhibits assembled with a one-page TOC and one cover per exhibit.
Local validation
Installed each build into the localhost docassemble server with:
Generated PDFs at
http://localhostand extracted their TOC text:3, 5, 72, 3, 44, 6, …, 58Additional checks:
black --check docassemble/AssemblyLine/al_document.py docassemble/AssemblyLine/test_al_document.pygit diff --checkuv build --out-dir /tmp/issue884-distThe repository-wide mypy run still reports four unrelated existing errors in
language.py,al_general.py, andsessions.py; the changed module passes independently.