Fail tests that omit the # do not pre-load pragma - #75
Merged
Conversation
… commonly be authored by a naive LLM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Docassemble encounters a Python module, it will eagerly load it into memory. This can cause problems and slow-downs when this happens to a test file, especially when the test file loads dev-only dependencies or mocks a docassemble internal. It can cause unnecessary namespace collisions for other imported modules, too.
LLMs tend to add a lot of tests, and it can sometimes miss this (I've found many will handle it fine if there are enough existing tests with this pattern, but that's not reliable).
Best to just avoid this! This adds a test for this scenario.
Fix #68