Mirror SE5 contract: settingsVersion + video duration/resolution#279
Merged
Merged
Conversation
Adds the new optional fields published in subtitleedit#11142 to the three plugin-side PluginContract.cs mirrors (Plugin-Shared, TypewriterEffect, Haxor): PluginRequest: - VideoDurationSeconds (double?) - VideoWidth (int?) - VideoHeight (int?) - SettingsVersion (int?) PluginResponse: - SettingsVersion (int?) All fields are optional and null-safe: existing plugins compile and run unchanged, plugins on newer SE that don't write SettingsVersion behave as "unversioned" just like before. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Plugin-side counterpart to SubtitleEdit/subtitleedit#11142.
Updates the three
PluginContract.csmirrors so plugin authors can read the new fields without rolling their own struct:PluginRequestVideoDurationSeconds: double?VideoWidth: int?VideoHeight: int?SettingsVersion: int?PluginResponseSettingsVersion: int?All fields optional and null-safe. Existing plugins on older SE keep working unchanged; this just lets new plugins opt in to the richer request/response surface.
Touched:
se5/Plugin-Shared/PluginContract.cs,se5/TypewriterEffect/PluginContract.cs,se5/Haxor/PluginContract.cs. All 6 SE5 projects (the three above plus AmericanToBritish, BritishToAmerican, WordCensor that reference Plugin-Shared) build clean.Test plan
settingsVersion: 2from response and reads it back from request on the next run.🤖 Generated with Claude Code