[Refactor:System] Remove submitty_count from default#75
Draft
dagemcn wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Fixes Submitty Issue#11784 - This one of the companion PRs to Submitty PR#12609.
What is the new behavior?
submitty_count is longer installed in preparation for deprecation.
Other information?
This is a breaking change. Any autograding that uses the old submitty_count instead of submitty_count_ts will no longer work.
dagemcn/dockerimages:default-testadding it through docker UI)submitty_countwithwhere
IMAGE_NAMEis the name of the image, for example,dagemcn/dockerimages:default-testif you reused mine.3. Create a gradeable using submitty_count, (Tutorial examples 04, 06, and 07 all utilize submitty_count)
4. Test that submitty_count will not work in the config and that submitty_count_ts successfully runs
5. Also test that regular autograding works successfully on the image
Attached is a zip of a sample solution and gradeable config with both submitty_count and submitty_count_ts commands present for testing.
example.zip