Skip to content

Fix stripe layout setting appears twice when stripe addon is active#3194

Merged
Crabcyborg merged 1 commit into
masterfrom
fix_stripe_layout_setting_appears_twice_when_stripe_addon_is_active
Jul 20, 2026
Merged

Fix stripe layout setting appears twice when stripe addon is active#3194
Crabcyborg merged 1 commit into
masterfrom
fix_stripe_layout_setting_appears_twice_when_stripe_addon_is_active

Conversation

@Crabcyborg

@Crabcyborg Crabcyborg commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Bug Fixes
    • Prevented the Stripe Layout option from appearing twice when the Stripe add-on is active.

@deepsource-io

deepsource-io Bot commented Jul 20, 2026

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in 97a8bda...e126785 on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
PHP Jul 20, 2026 4:03p.m. Review ↗
JavaScript Jul 20, 2026 4:03p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: b285b7b0-16e4-44a9-ab96-7c21b530a86b

📥 Commits

Reviewing files that changed from the base of the PR and between 97a8bda and e126785.

📒 Files selected for processing (1)
  • stripe/views/action-settings/options.php

📝 Walkthrough

Walkthrough

The Stripe action settings template now returns early when FrmStrpHooksController exists, preventing the Layout option from being rendered twice while preserving the existing rendering logic otherwise.

Changes

Stripe layout setting rendering

Layer / File(s) Summary
Add Stripe rendering guard
stripe/views/action-settings/options.php
The template exits when FrmStrpHooksController is present, preventing duplicate Layout option output.
Estimated code review effort: 1 (Trivial) ~2 minutes
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: preventing the Stripe layout setting from appearing twice when the Stripe add-on is active.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix_stripe_layout_setting_appears_twice_when_stripe_addon_is_active

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Crabcyborg
Crabcyborg merged commit 057c563 into master Jul 20, 2026
43 of 49 checks passed
@Crabcyborg
Crabcyborg deleted the fix_stripe_layout_setting_appears_twice_when_stripe_addon_is_active branch July 20, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant