-
Notifications
You must be signed in to change notification settings - Fork 17
Replace Astropy logging with standard Python logging. #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Replace Astropy logging with standard Python logging. #177
Conversation
…ifice imports to use the central/global instance of logger
| import logging | ||
| import os | ||
| from contextlib import contextmanager | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may include good UX like Stingray have you can visit this functions
And then change console_handler (something like this)
console_handler.setFormatter(ColoredFormatter())There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the suggestion!!
A colored log would be a great enhancement. I would look forward to achieving this, once the current PR gets approval from maintainers.
|
Hey @Sudarshan-21 this PR looks good start to me:) @matteobachetti your review required. |



Fixes issue #102
This PR aims to eliminate the usage of Astropy logging and implement logging using Python's standard logging library.
edit 26/04/2025
As of now, with the current changes, the logging is successfully being done using the standard Python logging module.
Current behaviour can be seen at: HENDRICS/pull/177#issuecomment-2831530914
I need to know the purpose of the commented codes like:
in the
hendrics/tests/test_a_complete_run.pyand similar files, in order to migrate to their new standard logger counterpart.I would like to hear the inputs and reviews about any missing modifications, or failure of the new logging method.
@matteobachetti @bsipocz @kashish2210 @ankitkhushwaha