Fix correctness bugs and UX gaps in the housing stack

[dmccoystephenson]

Stacked on #105

This targets feature/homeless-and-renting (#105), not main — review it last, after #104 and #105.

Summary

A full multi-angle review (line-by-line, removed-behavior, cross-file, reuse, simplification, efficiency, altitude, conventions, and UX) of the whole housing/investments/homeless-and-renting stack turned up real issues. All fixed here.

Correctness

• Player.__init__ hardcoded energy=100, but a fresh player's homeTier=0 (Homeless) caps at 60 — new players started 40 energy over their own cap. Now derived from housing.HOUSING_TIERS[0]["maxEnergy"].
• moveHome() changed player.homeTier but never reclamped player.energy to the new (possibly lower) cap, so downgrading or being evicted left the player over-cap until their next sleep. Eviction now routes through moveHome() instead of duplicating the tier assignment inline, so it gets this reconciliation automatically.
• investments.typeInfo()/housing.tierInfo() silently wrapped around via Python's negative-index behavior on an out-of-range id instead of failing loudly; both now raise ValueError, and schemas/player.json gained matching maximum bounds.

UX — eviction was completely silent

• TimeService.increaseDay()/increaseTime() now return {"evicted": bool}. Every place a day can roll over (Home.sleep, Tavern.getDrunk, a multi-hour Docks.fish trip, and the main game loop as a catch-all) surfaces housing.EVICTION_MESSAGE when it happens.
• "Move to Rented Room (free)" was misleading — it now discloses the recurring $10/day rent up front. "+$X" cash-back downgrade label is now "get $X back".
• Energy is shown as "current/cap" (not just current) in all three front-ends (console, pygame, web).

Cleanup

• netCostToMove() simplified (the status-gated ternaries were redundant with dict.get defaults).
• home.py's repeated adjacent-tier-move computation (built separately in _housingStatus() and manageHome()) is now computed once.
• manageInvestments() combined two PROPERTY_TYPES loops into one pass, backed by a new investments.ownedCounts().

Deliberately not changed (flagged, not worth the churn): menu-loop duplication across manageHome/manageInvestments/manageBusiness, investments' 1-based vs housing's 0-based indexing, displayStats()'s hand-rolled optional blocks vs achievements.py's data-driven pattern.

Test plan

• python3 -m pytest --verbose -vv --cov=src --cov-report=term-missing — 325 passed (up from 309 on feature/homeless-and-renting).
• Manual smoke test: fresh player energy/cap consistency, eviction via day rollover (summary + reclamp + bounds checks), all verified via direct API calls.

🤖 Generated with Claude Code