Skip to content

Add support for MacOS X (10.10)#1

Open
ankon wants to merge 4 commits intoStephan202:masterfrom
ankon:macosx-support
Open

Add support for MacOS X (10.10)#1
ankon wants to merge 4 commits intoStephan202:masterfrom
ankon:macosx-support

Conversation

@ankon
Copy link

@ankon ankon commented Jul 20, 2015

  • xargs -r: GNU extension, reimplemented using a shell function
  • sed -z: GNU extension, reimplemented by piping through echo (removing
    the newlines) and tr (adding the ',')
  • xargs -I{}: reimplemented using a for-loop, to avoid hitting
    the 255-byte limitation for eacho argument of xargs(1)

While there: replace the grep-parsing by a filtering for-loop, which
as a side-effect fixes command line arguments with quotes due to the use
of eval.

* xargs -r: GNU extension, reimplemented using a shell function
* sed -z: GNU extension, reimplemented by piping through echo (removing
  the newlines) and tr (adding the ',')
* xargs -I{}: reimplemented using a for-loop, to avoid hitting
  the 255-byte limitation for eacho argument of xargs(1)

While there: replace the grep-parsing by a filtering for-loop, which
as a side-effect fixes command line arguments with quotes due to the use
of eval.
@Stephan202
Copy link
Owner

You basically rewrote it ;)

Good point on using tr(1). Will review the other changes later today and merge. Really a shame that cross-platform scripts always seem to boil down to reinventing the wheel :(.

@ankon
Copy link
Author

ankon commented Jul 21, 2015

"Hammered it into working in my environment" :)

@Stephan202
Copy link
Owner

Alright, added some notes. One last thing: we now have lower and upper-case variable names, as well as names with and without a leading underscore. Shall we settle on one style?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants