Open
Conversation
* xargs -r: GNU extension, reimplemented using a shell function
* sed -z: GNU extension, reimplemented by piping through echo (removing
the newlines) and tr (adding the ',')
* xargs -I{}: reimplemented using a for-loop, to avoid hitting
the 255-byte limitation for eacho argument of xargs(1)
While there: replace the grep-parsing by a filtering for-loop, which
as a side-effect fixes command line arguments with quotes due to the use
of eval.
Owner
|
You basically rewrote it ;) Good point on using |
This should improve the speed a bit, and also avoids issues with files-with-spaces
Author
|
"Hammered it into working in my environment" :) |
Owner
|
Alright, added some notes. One last thing: we now have lower and upper-case variable names, as well as names with and without a leading underscore. Shall we settle on one style? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the newlines) and tr (adding the ',')
the 255-byte limitation for eacho argument of xargs(1)
While there: replace the grep-parsing by a filtering for-loop, which
as a side-effect fixes command line arguments with quotes due to the use
of eval.