Skip to content

Package updates - #1734

Open
bart-vmware wants to merge 3 commits into
mainfrom
package-updates
Open

Package updates#1734
bart-vmware wants to merge 3 commits into
mainfrom
package-updates

Conversation

@bart-vmware

@bart-vmware bart-vmware commented Sep 8, 2026

Copy link
Copy Markdown
Member

Description

Package updates that affect Steeltoe users

  • Consul from 1.7.14.* to 1.8.*: The only change is that the package now follows SemVer
  • Serilog.Extensions.Logging from 9.0.* to 10.0.*: Adds a net10.0 target (released 10 months ago)
  • Serilog.Settings.Configuration from 9.0.* to 10.0.*: Adds a net10.0 target and minor fixes (released 9 months ago)

Notes about internal dependency updates

  • Microsoft.Azure.Cosmos from 3.58.* to 3.62.*: Should update Samples and NetCoreToolTemplates likewise; requires explicit reference to Newtonsoft.Json
  • MongoDB.Driver from 3.8.* to 3.11.*: Should update Samples and NetCoreToolTemplates likewise
  • MySql.Data from 9.7.* to 26.7.*: Should update Samples and NetCoreToolTemplates likewise
  • Microsoft.CodeAnalysis.PublicApiAnalyzers: Changes to PublicAPI shipped files because Delegate.Invoke is now required
  • Microsoft.Extensions.TimeProvider.Testing from 10.0.* to 10.9.*: This package was assumed to version along with the runtime, which appears not to be the case.
  • SonarAnalyzer.CSharp from 10.25.0.139117 to 10.33.0.1635: Changes in rules (see below); updated Steeltoe way in SonarCloud to match up
  • Sorted PackageReference entries alphabetically.

Full ReSharper code cleanup run at: https://github.com/SteeltoeOSS/Steeltoe/actions/runs/34225245010.

Sonar rule changes

Change Rule Default Setting Steeltoe Override Description
- S4792 Configuring loggers is security-sensitive
* S5042 Warning -> None Guard against "Zip Bomb" attacks
+ S8949 Warning Use overload that takes CancellationToken
+ S8969 Warning None (false positives, already checked in IDE* and ReSharper) ! operators should not be redundant
+ S8970 Warning Don't use ! when nullable disabled
+ S8717 [SonarCloud-only] Don't use multiple [Key] attributes in EF Core
+ S8718 [SonarCloud-only] About EF Core client-evaluated default values
+ S8733 [SonarCloud-only] Use AsSplitQuery in EF Core
+ S8747 [SonarCloud-only] Don't narrow column types in EF Core migrations
+ S9022 [SonarCloud-only] Duplicate Include calls in EF Core
+ S9129 [SonarCloud-only] Merge include chains in EF Core

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation and/or Samples, add linked PRs here.
    - Align with Steeltoe package updates Samples#477
    - Align with Steeltoe package updates NetCoreToolTemplates#150
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@bart-vmware bart-vmware added Type/infrastructure ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Sep 8, 2026
@bart-vmware bart-vmware added this to the 4.3.0 milestone Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary - All Code Coverage (ubuntu-latest)

Line coverage Branch coverage

Assembly Line coverage Branch coverage
Steeltoe.Bootstrap.AutoConfiguration 97.4% 83.3%
Steeltoe.Common 86.4% 77%
Steeltoe.Common.Certificates 97.2% 80.2%
Steeltoe.Common.Hosting 83.5% 65%
Steeltoe.Common.Http 97.4% 80.9%
Steeltoe.Common.Logging 80.6% 56.2%
Steeltoe.Common.Net 64.5% 66.6%
Steeltoe.Configuration.Abstractions 96.3% 89.4%
Steeltoe.Configuration.CloudFoundry 98.4% 92.7%
Steeltoe.Configuration.ConfigServer 91.6% 86.2%
Steeltoe.Configuration.Encryption 97.6% 87.8%
Steeltoe.Configuration.Kubernetes.ServiceBindings 95.6% 82.6%
Steeltoe.Configuration.Placeholder 93.8% 82.6%
Steeltoe.Configuration.RandomValue 93.2% 83.3%
Steeltoe.Configuration.SpringBoot 98.3% 85%
Steeltoe.Connectors 94.4% 85.3%
Steeltoe.Connectors.EntityFrameworkCore 81% 65.3%
Steeltoe.Discovery.Configuration 96.3% 75%
Steeltoe.Discovery.Consul 91.5% 84%
Steeltoe.Discovery.Eureka 91.6% 81.3%
Steeltoe.Discovery.HttpClients 89.9% 91.4%
Steeltoe.Logging.Abstractions 99.4% 95.6%
Steeltoe.Logging.DynamicConsole 100% 92.3%
Steeltoe.Logging.DynamicSerilog 99.1% 95.4%
Steeltoe.Management.Abstractions 100% 100%
Steeltoe.Management.Endpoint 96% 87.1%
Steeltoe.Management.GitProperties.Build 95.1% 83.9%
Steeltoe.Management.Prometheus 95.8% 76.9%
Steeltoe.Management.Tasks 95.2% 80%
Steeltoe.Management.Tracing 100% 75%
Steeltoe.Security.Authentication.JwtBearer 100% 93.7%
Steeltoe.Security.Authentication.OpenIdConnect 87.7% 66.6%
Steeltoe.Security.Authorization.Certificate 95.6% 61.5%
Steeltoe.Security.DataProtection.Redis 100% ****

TimHess
TimHess previously approved these changes Sep 8, 2026

@TimHess TimHess left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bart-vmware added a commit to SteeltoeOSS/Samples that referenced this pull request Sep 8, 2026
bart-vmware added a commit to SteeltoeOSS/NetCoreToolTemplates that referenced this pull request Sep 8, 2026
Changed rules:
-S4792       // Configuring loggers is security-sensitive
*S5042 Warning -> None     // Guard against "Zip Bomb" attacks
+S8949: Warning      // Use overload that takes CancellationToken
+S8969: Warning, Steeltoe: None (false positives) // ! operators should not be redundant
+S8970: Warning      // Don't use ! when nullable disabled
+S8717 [SonarCloud-only]     // Don't use multiple [Key] attributes in EF Core
+S8718 [SonarCloud-only]     // About EF Core client-evaluated default values
+S8733 [SonarCloud-only]    // Use AsSplitQuery in EF Core
+S8747 [SonarCloud-only]    // Don't narrow column types in EF Core migrations
+S9022 [SonarCloud-only]    // Duplicate Include calls in EF Core
+S9129 [SonarCloud-only]    // Merge include chains in EF Core
@sonarqubecloud

sonarqubecloud Bot commented Sep 8, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ReleaseLine/4.x Identified as a feature/fix for the 4.x release line Type/infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants